ATH11K Archive mirror
 help / color / mirror / Atom feed

From: "Nicolas Escande" <nico.escande@gmail.com>
To: <ath11k@lists.infradead.org>, <ath12k@lists.infradead.org>
Subject: ath12k & ath11k beacon miss detection
Date: Tue, 20 Feb 2024 18:11:37 +0100	[thread overview]
Message-ID: <CZA2NS7J83D4.18SU6W9R96KPY@gmail.com> (raw)

Hi there,

I found that when using QCN9274 iun station mode, we never get disconnected from
the AP even if it stops beaconning. Using iw I can see the "inactive time"
increasing without supplicant ever getting a beacon miss event.

From what I gathered, given we set the flag CONNECTION_MONITOR using
ieee80211_hw_set in __ath12k_mac_register (mac.c) we should detect the
connection loss and call ieee80211_connection_loss() at some point. Right now,
there is no such mecanism in ath12k.

So looking at ath11k code I found out that in that driver we have a specific
WMI event "WMI_ROAM_EVENTID" that can report a WMI_ROAM_REASON_BEACON_MISS that
in turn ends up calling ieee80211_beacon_loss after some time.

But trying ath11k & qcn9074 in station mode yielded the same result, we never
get the roam event and never get disconnected either.

So going back to ath10k this time, the code isn't exactly the same but even then
we had the same wmi event, with the same WMI_ROAM_REASON_BEACON_MISS and we'd
call ath10k_mac_handle_beacon_miss which in turn ends up calling
ieee80211_beacon_loss via a work item.

And using ath10k on qca9888 works well for me.

So I have a few questions:
  - is this supposed to work on ath11k ? Does it not work for me specifically
    because of my chipset ? Or are we missing some wmi config ?
  - as the code to handle the roam event is missing/commented out in ath12k will
    it be a different mecanism to detect connection loss ? Or it'll be the same
    and you guys just did not have time yet to tackle this ?

I'm happy to add the missing code to fix that use case in both drivers but I'll
need some insight from you ath folks on this.

Thanks  

next             reply	other threads:[~2024-02-20 17:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 17:11 Nicolas Escande [this message]
2024-02-21  0:46 ` ath12k & ath11k beacon miss detection Jeff Johnson
2024-02-23  8:39   ` Nicolas Escande
2024-03-15 10:06   ` Nicolas Escande
2024-03-15 19:55     ` Jeff Johnson
2024-03-18  8:33       ` Nicolas Escande
2024-02-21  7:02 ` Kalle Valo
2024-02-23  8:42   ` Nicolas Escande
2024-02-23 10:17     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CZA2NS7J83D4.18SU6W9R96KPY@gmail.com \
    --to=nico.escande@gmail.com \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).