From: Kalle Valo <kvalo@kernel.org>
To: P Praneesh <quic_ppranees@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
P Praneesh <quic_ppranees@quicinc.com>,
Baochen Qiang <quic_bqiang@quicinc.com>
Subject: Re: [PATCH 1/3] wifi: ath12k: change DMA direction while mapping reinjected packets
Date: Sat, 25 May 2024 08:57:11 +0000 (UTC) [thread overview]
Message-ID: <171662742964.564311.15908765736182779932.kvalo@kernel.org> (raw)
In-Reply-To: <20240520070045.631029-2-quic_ppranees@quicinc.com>
P Praneesh <quic_ppranees@quicinc.com> wrote:
> For fragmented packets, ath12k reassembles each fragment as a normal
> packet and then reinjects it into HW ring. In this case, the DMA
> direction should be DMA_TO_DEVICE, not DMA_FROM_DEVICE. Otherwise,
> an invalid payload may be reinjected into the HW and
> subsequently delivered to the host.
>
> Given that arbitrary memory can be allocated to the skb buffer,
> knowledge about the data contained in the reinjected buffer is lacking.
> Consequently, there’s a risk of private information being leaked.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00209-QCAHKSWPL_SILICONZ-1
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Co-developed-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
3 patches applied to ath-next branch of ath.git, thanks.
33322e3ef074 wifi: ath12k: change DMA direction while mapping reinjected packets
073f9f249eec wifi: ath12k: fix invalid memory access while processing fragmented packets
a57ab7cced45 wifi: ath12k: fix firmware crash during reo reinject
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240520070045.631029-2-quic_ppranees@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-05-25 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 7:00 [PATCH 0/3] wifi: ath12k: fix issues in rx fragmentation path P Praneesh
2024-05-20 7:00 ` [PATCH 1/3] wifi: ath12k: change DMA direction while mapping reinjected packets P Praneesh
2024-05-20 23:38 ` Jeff Johnson
2024-05-25 8:57 ` Kalle Valo [this message]
2024-05-20 7:00 ` [PATCH 2/3] wifi: ath12k: fix invalid memory access while processing fragmented packets P Praneesh
2024-05-20 23:38 ` Jeff Johnson
2024-05-20 7:00 ` [PATCH 3/3] wifi: ath12k: fix firmware crash during reo reinject P Praneesh
2024-05-20 23:38 ` Jeff Johnson
2024-05-21 8:50 ` Nicolas Escande
2024-05-22 7:15 ` Praneesh P
2024-05-22 7:28 ` Nicolas Escande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171662742964.564311.15908765736182779932.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
--cc=quic_ppranees@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).