From: Kalle Valo <kvalo@kernel.org>
To: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] wifi: ath12k: Dump additional Tx PDEV HTT stats
Date: Fri, 31 May 2024 21:00:22 +0300 [thread overview]
Message-ID: <87plt1vp3d.fsf@kernel.org> (raw)
In-Reply-To: <1be3531d-b550-4b19-93bb-d41e93362e19@quicinc.com> (Ramya Gnanasekar's message of "Tue, 28 May 2024 22:18:18 +0530")
Ramya Gnanasekar <quic_rgnanase@quicinc.com> writes:
> On 5/28/2024 4:36 PM, Kalle Valo wrote:
>> Ramya Gnanasekar <quic_rgnanase@quicinc.com> writes:
>>
>>>>> +static inline void
>>>>> +ath12k_htt_print_tx_pdev_mu_ppdu_dist_stats_tlv(const void *tag_buf,
>>>>> + struct debug_htt_stats_req *stats_req)
>>>>> +{
>>>>> + const struct ath12k_htt_tx_pdev_mu_ppdu_dist_stats_tlv
>>>>> *htt_stats_buf = tag_buf;
>>>>> + char *mode;
>>>>> + u8 j, hw_mode, i, str_buf_len;
>>>>> + u8 *buf = stats_req->buf;
>>>>> + u32 len = stats_req->buf_len;
>>>>> + u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE;
>>>>> + u32 stats_value;
>>>>> + u8 max_ppdu = ATH12K_HTT_STATS_MAX_NUM_MU_PPDU_PER_BURST;
>>>>> + u8 max_sched = ATH12K_HTT_STATS_MAX_NUM_SCHED_STATUS;
>>>>> + char str_buf[ATH12K_HTT_MAX_STRING_LEN];
>>>>> +
>>>>> + hw_mode = le32_to_cpu(htt_stats_buf->hw_mode);
>>>>> +
>>>>> + switch (hw_mode) {
>>>>> + case ATH12K_HTT_STATS_HWMODE_AC:
>>>>> + len += scnprintf(buf + len, buf_len - len,
>>>>> + "HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS:\n");
>>>>> + mode = "ac";
>>>>> + break;
>>>>> + case ATH12K_HTT_STATS_HWMODE_AX:
>>>>> + mode = "ax";
>>>>> + break;
>>>>> + case ATH12K_HTT_STATS_HWMODE_BE:
>>>>> + mode = "be";
>>>>> + break;
>>>>> + default:
>>>>> + return;
>>>>> + }
>>>>
>>>> Why are we not adding "HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS:\n" with
>>>> ax and be modes?
>>>>
>>> Sorry for the delayed response. I was on OoO for a week.
>>
>> No worries.
>>
>>> We will receive this TLV for each hw modes. Since
>>> "HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS:\n" is header and it would be
>>> suffice to print it once, hence added it inside hw mode ac which will be
>>> the first hw mode integrated inside the TLV.
>>
>> I would have expected that we print that outside of
>> ath12k_htt_print_tx_pdev_mu_ppdu_dist_stats_tlv(), before the function
>> is called at all.
>>
>
> Function itself will be called more than once.
Sure, I got that. But I still think it is not really good design to
print it like that.
Maybe the output could be something like below? Or print the mode
separate in the first line?
HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS:
ac_mu_mimo_num_seq_posted_nr4 = 0
ac_mu_mimo_num_ppdu_posted_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0,
ac_mu_mimo_num_ppdu_completed_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0,
ac_mu_mimo_num_seq_term_status_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0,
....
HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS:
ax_mu_mimo_num_seq_posted_nr4 = 0
ax_mu_mimo_num_ppdu_posted_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0,
ax_mu_mimo_num_ppdu_completed_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0,
ax_mu_mimo_num_seq_term_status_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0,
ax_mu_mimo_num_seq_posted_nr8 = 0
ax_mu_mimo_num_ppdu_posted_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0,
ax_mu_mimo_num_ppdu_completed_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0,
ax_mu_mimo_num_seq_term_status_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0,
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-05-31 18:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 5:08 [PATCH v2 0/5] wifi: ath12k: Add support to enable debugfs_htt_stats Ramya Gnanasekar
2024-05-10 5:08 ` [PATCH v2 1/5] " Ramya Gnanasekar
2024-05-10 19:53 ` Jeff Johnson
2024-05-21 7:49 ` Kalle Valo
2024-05-27 10:42 ` Ramya Gnanasekar
2024-05-10 5:08 ` [PATCH v2 2/5] wifi: ath12k: Add htt_stats_dump file ops support Ramya Gnanasekar
2024-05-10 19:53 ` Jeff Johnson
2024-05-21 7:53 ` Kalle Valo
2024-05-10 5:08 ` [PATCH v2 3/5] wifi: ath12k: Fix Pdev id in HTT stats request for WCN7850 Ramya Gnanasekar
2024-05-10 19:53 ` Jeff Johnson
2024-05-21 7:57 ` Kalle Valo
2024-05-23 12:34 ` Lingbo Kong
2024-05-23 12:55 ` Kalle Valo
2024-05-23 14:04 ` Lingbo Kong
2024-05-10 5:08 ` [PATCH v2 4/5] wifi: ath12k: Add support to parse requested stats_type Ramya Gnanasekar
2024-05-10 19:53 ` Jeff Johnson
2024-05-10 5:08 ` [PATCH v2 5/5] wifi: ath12k: Dump additional Tx PDEV HTT stats Ramya Gnanasekar
2024-05-10 19:54 ` Jeff Johnson
2024-05-21 8:00 ` Kalle Valo
2024-05-27 9:38 ` Ramya Gnanasekar
2024-05-28 11:06 ` Kalle Valo
2024-05-28 16:48 ` Ramya Gnanasekar
2024-05-31 18:00 ` Kalle Valo [this message]
2024-05-31 19:05 ` Ramya Gnanasekar
2024-05-21 7:40 ` [PATCH v2 0/5] wifi: ath12k: Add support to enable debugfs_htt_stats Kalle Valo
2024-05-27 10:44 ` Ramya Gnanasekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plt1vp3d.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rgnanase@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).