From: Kalle Valo <kvalo@kernel.org>
To: Aloka Dixit <quic_alokad@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: use correct flag field for 320 MHz
Date: Mon, 18 Mar 2024 20:49:37 +0200 [thread overview]
Message-ID: <87v85jbcji.fsf@kernel.org> (raw)
In-Reply-To: <4940b6cf-a68d-4799-ccf3-f90dcc105e3e@quicinc.com> (Aloka Dixit's message of "Mon, 18 Mar 2024 11:40:02 -0700")
Aloka Dixit <quic_alokad@quicinc.com> writes:
> On 3/18/2024 10:54 AM, Kalle Valo wrote:
>> Kalle Valo <kvalo@kernel.org> writes:
>>
>>> Aloka Dixit <quic_alokad@quicinc.com> writes:
>>>
>>>> WMI_PEER_EXT_320MHZ (0x2) is defined as an extended flag, replace
>>>> peer_flags by peer_flags_ext while sending peer data.
>>>>
>>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>>>
>>>> Fixes: 6734cf9b4cc7 ("wifi: ath12k: peer assoc for 320 MHz")
>>>> Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
>>>
>>> What does this fix from user's point of view? Does it mean that 320 MHz
>>> chanels were broken before and this commit fixes that? I can ammend the
>>> commit message.
>> And what about WCN7850? Does it work the same?
>
> 320 MHz association was broken. It was a re-basing error while sending
> the original patch because the correct field was added during testing,
> still used that way internally too. I have not tested WCN7850 on this
> patch but yes will require the same field. Current code was setting
> QOS bit instead of 320MHz.
Thanks, does this look ok:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=c4ade6bdf3d1a2d9d05606a85431f154559d5a80
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-03-18 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 20:46 [PATCH] wifi: ath12k: use correct flag field for 320 MHz Aloka Dixit
2024-03-14 21:24 ` Jeff Johnson
2024-03-18 15:51 ` Kalle Valo
2024-03-18 17:54 ` Kalle Valo
2024-03-18 18:40 ` Aloka Dixit
2024-03-18 18:49 ` Kalle Valo [this message]
2024-03-18 19:24 ` Aloka Dixit
2024-03-20 10:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v85jbcji.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_alokad@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).