From: Andrew Morton <akpm@linux-foundation.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] tree-wide: replace config_enabled() with IS_ENABLED()
Date: Mon, 13 Jun 2016 06:24:45 -0000 [thread overview]
Message-ID: <20160607152930.71273719bdaea322814213d0@linux-foundation.org> (raw)
In-Reply-To: <1465215656-20569-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, 6 Jun 2016 21:20:56 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> The use of config_enabled() against config options is ambiguous.
> In practical terms, config_enabled() is equivalent to IS_BUILTIN(),
> but the author might have used it for the meaning of IS_ENABLED().
> Using IS_ENABLED(), IS_BUILTIN(), IS_MODULE() etc. makes the
> intention clearer.
>
> This commit replaces config_enabled() with IS_ENABLED() where
> possible. This commit is only touching bool config options.
>
> I noticed two cases where config_enabled() is used against a tristate
> option:
>
> - config_enabled(CONFIG_HWMON)
> [ drivers/net/wireless/ath/ath10k/thermal.c ]
>
> - config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)
> [ drivers/gpu/drm/gma500/opregion.c ]
>
> I did not touch them because they should be converted to IS_BUILTIN()
> in order to keep the logic, but I was not sure it was the authors'
> intention.
Well, we do want to be able to remove config_enabled() altogether if
we're going to do this. So please later send along a patch which makes
a best-effort fix of the unclear usages and let's zap the thing.
If those fixes weren't quite correct then there will be a build error
(drivers/net/wireless/ath/ath10k/thermal.c) or no change in behaviour
(drivers/gpu/drm/gma500/opregion.c).
prev parent reply other threads:[~2016-06-13 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 12:35 [ath9k-devel] [PATCH] tree-wide: replace config_enabled() with IS_ENABLED() Masahiro Yamada
2016-06-06 16:01 ` Kees Cook
2016-06-13 6:24 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607152930.71273719bdaea322814213d0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).