From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [Make-wifi-fast] [RFC] ath9k: Measure per-station airtime usage
Date: Mon, 30 May 2016 13:27:16 -0000 [thread overview]
Message-ID: <87bn3nvfpx.fsf@toke.dk> (raw)
In-Reply-To: <CA+BoTQnzaE0hF7ja+BCT6-_WuMgG+e_Ln_G7PWh5TwHJ2ixVFA@mail.gmail.com> (Michal Kazior's message of "Mon, 30 May 2016 14:35:37 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
>> +void ath_debug_tx_airtime(struct ath_softc *sc,
>> + struct ath_node *an,
>> + struct ath_tx_status *ts)
>> +{
>> + struct ath_airtime_stats *astats;
>> +
>> + rcu_read_lock();
>> +
>> + astats = &an->airtime_stats;
>> + astats->tx_airtime += ts->duration;
>
> I'm not ath9k expert but this seems to be oblivious to tx retries. The
> ts->duration is acquired from the last used tx rate for given frame.
> Or am I missing something?
No, don't think you are. Wasn't sure what exactly that duration field
included, but I think you're right that it doesn't factor in retries.
> I think you should use ts->ts_rateindex and ts->ts_longretry to factor
> in retries (see ath_tx_rc_status).
I'll go digging. Thanks, this was exactly the kind of feedback I had
hoped for! :)
-Toke
prev parent reply other threads:[~2016-05-30 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 13:56 [ath9k-devel] [RFC] ath9k: Measure per-station airtime usage Toke Høiland-Jørgensen
2016-05-30 12:35 ` [ath9k-devel] [Make-wifi-fast] " Michal Kazior
2016-05-30 13:27 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn3nvfpx.fsf@toke.dk \
--to=toke@toke.dk \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).