From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Colin King <colin.king@canonical.com>,
Ian Kent <raven@themaw.net>,
autofs@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] autofs: remove redundant assignment to variable err
Date: Sun, 1 Sep 2019 17:30:37 +0200 [thread overview]
Message-ID: <01ec26e2-6fd9-5ea0-4ef7-6a47e00bb2c5@wanadoo.fr> (raw)
In-Reply-To: <20190901152251.11374-1-colin.king@canonical.com>
Le 01/09/2019 à 17:22, Colin King a écrit :
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable err is being assigned a value that is never read and
> is being re-assigned a little later on. The assignment is redundant
> and hence can be removed.
>
> Addresses-Coverity: ("Ununsed value")
Ununsed?
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/autofs/dev-ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/autofs/dev-ioctl.c b/fs/autofs/dev-ioctl.c
> index a3cdb0036c5d..65d84b4d4464 100644
> --- a/fs/autofs/dev-ioctl.c
> +++ b/fs/autofs/dev-ioctl.c
> @@ -422,7 +422,7 @@ static int autofs_dev_ioctl_requester(struct file *fp,
> struct autofs_info *ino;
> struct path path;
> dev_t devid;
> - int err = -ENOENT;
> + int err;
>
> /* param->path has been checked in validate_dev_ioctl() */
>
prev parent reply other threads:[~2019-09-01 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 15:22 [PATCH] autofs: remove redundant assignment to variable err Colin King
2019-09-01 15:30 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ec26e2-6fd9-5ea0-4ef7-6a47e00bb2c5@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=autofs@vger.kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).