From: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
To: raven@themaw.net, jeffm@suse.com
Cc: autofs@vger.kernel.org, Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Subject: [PATCH v2] autofs: Add WARN_ON(1) for non dir/link inode case
Date: Mon, 4 Jul 2016 12:40:03 +0900 [thread overview]
Message-ID: <1467603603-1530-1-git-send-email-kusumi.tomohiro@gmail.com> (raw)
It's invalid if the given mode is neither dir nor link,
so warn on else case.
(v2 changed BUG_ON to WARN_ON)
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
---
fs/autofs4/inode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index ad0ee93..89174ec 100644
--- a/fs/autofs4/inode.c
+++ b/fs/autofs4/inode.c
@@ -305,6 +305,7 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)
if (autofs_type_trigger(sbi->type))
__managed_dentry_set_managed(root);
+ WARN_ON(!root_inode->i_fop || !root_inode->i_op);
root_inode->i_fop = &autofs4_root_operations;
root_inode->i_op = &autofs4_dir_inode_operations;
@@ -368,7 +369,8 @@ struct inode *autofs4_get_inode(struct super_block *sb, umode_t mode)
inode->i_fop = &autofs4_dir_operations;
} else if (S_ISLNK(mode)) {
inode->i_op = &autofs4_symlink_inode_operations;
- }
+ } else
+ WARN_ON(1);
return inode;
}
--
2.5.5
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
next reply other threads:[~2016-07-04 3:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 3:40 Tomohiro Kusumi [this message]
2016-07-07 6:09 ` [PATCH v2] autofs: Add WARN_ON(1) for non dir/link inode case Ian Kent
2016-07-07 6:46 ` Tomohiro Kusumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467603603-1530-1-git-send-email-kusumi.tomohiro@gmail.com \
--to=kusumi.tomohiro@gmail.com \
--cc=autofs@vger.kernel.org \
--cc=jeffm@suse.com \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).