b4-sent.feeds.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Jackson <tjackson9431@gmail.com>
To: fstests@vger.kernel.org
Cc: Christian Brauner <brauner@kernel.org>,
	 Seth Forshee <sforshee@kernel.org>,
	Taylor Jackson <tjackson9431@gmail.com>,
	 Zorro Lang <zlang@redhat.com>
Subject: [PATCH] generic/645: Add hint for expected failure with old kernel
Date: Wed, 17 Apr 2024 19:34:24 +0000	[thread overview]
Message-ID: <20240417-generic-test-645-v1-1-7f6f496af06a@gmail.com> (raw)

The following hint is added to reflect that any old kernel
without kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return
-EINVAL when no map is written”) is expected to fail this generic
645 test since without that commit, mount_setattr won’t return
EINVAL when attempting to create an idmapped mount using a user
namespace with no mappings.

Reported-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Taylor Jackson <tjackson9431@gmail.com>
---
 tests/generic/645 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/generic/645 b/tests/generic/645
index 556d2450..bcc3e3b5 100755
--- a/tests/generic/645
+++ b/tests/generic/645
@@ -17,6 +17,8 @@ _begin_fstest auto quick idmapped mount
 _supported_fs generic
 _require_idmapped_mounts
 _require_test
+_fixed_by_kernel_commit dacfd001eaf2 \
+	"fs/mnt_idmapping.c: Return -EINVAL when no map is written"
 
 echo "Silence is golden"
 

---
base-commit: e72e052d56c3f05e533f4b67056f86931f688368
change-id: 20240417-generic-test-645-18750d02523e

Best regards,
-- 
Taylor Jackson <tjackson9431@gmail.com>


                 reply	other threads:[~2024-04-17 19:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240417-generic-test-645-v1-1-7f6f496af06a@gmail.com \
    --to=tjackson9431@gmail.com \
    --cc=brauner@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=sforshee@kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).