From: Johannes Berg <johannes@sipsolutions.net>
To: Julia Lawall <julia.lawall@lip6.fr>,
Remington Furman <remicles2@gmail.com>
Cc: backports@vger.kernel.org, cocci <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Parse error with genl-const.cocci
Date: Mon, 25 Jun 2018 22:33:52 +0200 [thread overview]
Message-ID: <1529958832.10347.5.camel@sipsolutions.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1712141614460.5502@hadrien>
Julia,
> I updated the github version of Coccinelle such that
> patches/0027-genl-const/genl-const.cocci
> will almost parse correctly. The only thing that remains is to change
> attribute into attribute name.
I'm not sure why, but for some reason I thought back then (https://git.k
ernel.org/pub/scm/linux/kernel/git/backports/backports.git/commit/?id=98
272f479c2126a135dfcb12484e93d5888164ab) that the following would work
with 1.0.6:
@@
attribute name __genl_const;
@@
(
-const struct genl_multicast_group
+__genl_const struct genl_multicast_group
|
-const struct genl_ops
+__genl_const struct genl_ops
)
However, Hauke pointed out it doesn't, and I can confirm. On 1.0.6, I
can't get this to work at all, it refuses to parse "attribute name" and
it refuses to parse the patch part with just "attribute".
Is there any way to get this to work again?
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2018-06-25 20:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 5:43 Parse error with genl-const.cocci Remington Furman
2017-12-01 8:27 ` Johannes Berg
2017-12-01 9:18 ` [Cocci] " Julia Lawall
2017-12-01 9:29 ` Johannes Berg
2017-12-01 10:00 ` Julia Lawall
2017-12-12 15:19 ` Remington Furman
2017-12-14 15:16 ` Julia Lawall
2017-12-19 9:41 ` Johannes Berg
2018-06-25 20:33 ` Johannes Berg [this message]
2017-12-01 17:57 ` Remington Furman
2017-12-01 18:02 ` Johannes Berg
2017-12-01 18:09 ` Remington Furman
2017-12-01 23:48 ` Remington Furman
2017-12-02 7:47 ` Johannes Berg
2017-12-01 18:57 ` [Cocci] " Julia Lawall
2017-12-01 19:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529958832.10347.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=remicles2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).