From: Johannes Berg <johannes@sipsolutions.net>
To: Hauke Mehrtens <hauke@hauke-m.de>, backports@vger.kernel.org
Subject: Re: [PATCH 3/3] backports: Add kvcalloc()
Date: Tue, 19 Nov 2019 20:38:34 +0100 [thread overview]
Message-ID: <26dd2a9e3582668e8d708832d24ec5f5d331a520.camel@sipsolutions.net> (raw)
In-Reply-To: <3325f5fa-aa94-cf5b-cfdd-810495a390e0@hauke-m.de>
On Tue, 2019-11-19 at 20:12 +0100, Hauke Mehrtens wrote:
> On 11/19/19 9:59 AM, Johannes Berg wrote:
> > On Sat, 2019-11-16 at 19:36 +0100, Hauke Mehrtens wrote:
> > > kvcalloc() was added in kernel commit 1c542f38ab8d ("mm: Introduce
> > > kvcalloc()") and is now used by the fq header filers.
> >
> > Oops, I did the same some time ago but forgot to send it out.
> >
> > > +{
> > > + return kvmalloc_array(n, size, flags | __GFP_ZERO);
> >
> > I did end up wondering though if __GFP_ZERO actually worked on all old
> > kernels?
>
> __GFP_ZERO is at least defined on old kernel versions. I haven't seen an
> error when building against 3.14 for example and it is already used
> somewhere else in this file.
I know. I just have a vague recollection it didn't always work for any
kind of allocation. I guess I should go search tomorrow...
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
prev parent reply other threads:[~2019-11-19 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 18:36 [PATCH 1/3] backports: Add return value to backport_pci_disable_link_state() Hauke Mehrtens
2019-11-16 18:36 ` [PATCH 2/3] backports: Adapt to changes to skb_get_hash_perturb() Hauke Mehrtens
2019-11-19 9:00 ` Johannes Berg
2019-11-16 18:36 ` [PATCH 3/3] backports: Add kvcalloc() Hauke Mehrtens
2019-11-19 8:59 ` Johannes Berg
2019-11-19 19:12 ` Hauke Mehrtens
2019-11-19 19:38 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26dd2a9e3582668e8d708832d24ec5f5d331a520.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=hauke@hauke-m.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).