From: Aaron Komisar <aaron.komisar@tandemg.com>
To: Wan-Hua Chang <winnie.chang@cypress.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: "backports@vger.kernel.org" <backports@vger.kernel.org>,
"Chi-Hsien.Lin@cypress.com" <chi-hsien.lin@cypress.com>
Subject: Re: [PATCH] Updating id field in backports genl family
Date: Tue, 26 Jun 2018 06:54:46 +0000 [thread overview]
Message-ID: <AM4PR0202MB29164C902F2A904E875C123EF8490@AM4PR0202MB2916.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <20180626060717.GA33209@aremote01.aus.cypress.com>
On Tue, Jun 26, 2018 at 09:07:13PM +0300, Wan-Hua Chang wrote:
>> Looking at this again ...
>>=20
>> > I see the patch causes compiling error becasue family->family is not
>> > found when LINUX_VERSION >=3D 3.13
>>=20
>> Yeah, that seems right.
>>=20
>> > backports/backport/backport-include/genetlink.h
>> > struct backport_genl_fmaily is only defined when LINUX_VERSION < 3.13
>> >=20
>> >=20
>> > And in backports/backport/compat/backport-3.13.c line 127=20
>> >=20
>> > family->id =3D family->family.id
>> >=20
>> > it looks like this line has done what the patch want to do. Is the
>> > comprehension correct?
>>=20
>> I don't think so. We call this function - via
>> __real_bp_extack_genl_register_family() - on copy->family, so we do need
>> to copy like Aaron said, we just need to make it conditional for kernel
>> < 3.13 because on 3.13 we don't use this sub-family thing.
>>=20
>> I've committed a fix - does that work for both of you? Aaron?
>Hi Johannes,=20
>Yes, the fix works for me, thanks.
Same here.
Thanks!
>
>>=20
>> johannes
=
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2018-06-26 6:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 10:29 [PATCH] Updating id field in backports genl family Wan-Hua Chang
2018-06-11 12:25 ` Johannes Berg
2018-06-12 1:50 ` Chi-Hsien Lin
2018-06-12 12:10 ` Aaron Komisar
2018-06-13 10:30 ` Wan-Hua Chang
2018-06-21 10:12 ` Wan-Hua Chang
2018-06-21 14:14 ` Aaron Komisar
2018-06-21 14:17 ` Johannes Berg
2018-06-25 16:40 ` Johannes Berg
2018-06-26 6:07 ` Wan-Hua Chang
2018-06-26 6:54 ` Aaron Komisar [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-24 10:57 Aaron Komisar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR0202MB29164C902F2A904E875C123EF8490@AM4PR0202MB2916.eurprd02.prod.outlook.com \
--to=aaron.komisar@tandemg.com \
--cc=backports@vger.kernel.org \
--cc=chi-hsien.lin@cypress.com \
--cc=johannes@sipsolutions.net \
--cc=winnie.chang@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).