From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH v2 1/5] batman-adv: mcast: remove now redundant single ucast forwarding
Date: Mon, 26 Dec 2022 18:09:11 +0100 [thread overview]
Message-ID: <3060990.e9J7NaK4W3@sven-l14> (raw)
In-Reply-To: <20221226161554.9657-2-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 2327 bytes --]
On Monday, 26 December 2022 17:15:50 CET Linus Lüssing wrote:
> The multicast code to send a multicast packet via multiple batman-adv
> unicast packets is not only capable of sending to multiple but also to a
> single node. Therefore we can safely remove the old, specialized, now
> redundant multicast-to-single-unicast code.
>
> The only functional change of this simplification is that the edge case
> of allowing a multicast packet with an unsnoopable destination address
> (224.0.0.0/24 or ff02::1) where only a single node has signaled interest
> in it via the batman-adv want-all-unsnoopables multicast flag is now
> transmitted via a batman-adv broadcast instead of a batman-adv unicast
> packet. Maintaining this edge case feature does not seem worth the extra
> lines of code and people should just not expect to be able to snoop and
> optimize such unsnoopable multicast addresses when bridges are involved.
>
> While at it also renaming a few items in the batadv_forw_mode enum to
> prepare for the new batman-adv multicast packet type.
>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> net/batman-adv/multicast.c | 248 ++------------------------------
> net/batman-adv/multicast.h | 38 +----
> net/batman-adv/soft-interface.c | 25 ++--
> 3 files changed, 33 insertions(+), 278 deletions(-)
Output of different failed tests
================================
ecsv/pu: headers
----------------
diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c
index 89ba1093..6f387e61 100644
--- a/net/batman-adv/multicast.c
+++ b/net/batman-adv/multicast.c
@@ -26,7 +26,6 @@
#include <linux/ipv6.h>
#include <linux/jiffies.h>
#include <linux/kernel.h>
-#include <linux/kref.h>
#include <linux/list.h>
#include <linux/lockdep.h>
#include <linux/netdevice.h>
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index c2fa0ef5..cd04ab27 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -48,7 +48,6 @@
#include "hard-interface.h"
#include "multicast.h"
#include "network-coding.h"
-#include "originator.h"
#include "send.h"
#include "translation-table.h"
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-12-26 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 16:15 [PATCH v2 0/5] Implementation of a Stateless Multicast Packet Type Linus Lüssing
2022-12-26 16:15 ` [PATCH v2 1/5] batman-adv: mcast: remove now redundant single ucast forwarding Linus Lüssing
2022-12-26 17:09 ` Sven Eckelmann [this message]
2022-12-26 16:15 ` [PATCH v2 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type Linus Lüssing
2022-12-26 17:33 ` Sven Eckelmann
2022-12-26 16:15 ` [PATCH v2 3/5] batman-adv: mcast: implement multicast packet reception and forwarding Linus Lüssing
2022-12-26 18:00 ` Sven Eckelmann
2022-12-26 16:15 ` [PATCH v2 4/5] batman-adv: mcast: implement multicast packet generation Linus Lüssing
2022-12-26 18:24 ` Sven Eckelmann
2022-12-26 16:15 ` [PATCH v2 5/5] batman-adv: mcast: shrink tracker packet after scrubbing Linus Lüssing
2022-12-26 18:50 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3060990.e9J7NaK4W3@sven-l14 \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).