From: Andrew Lunn <andrew@lunn.ch>
To: Sven Eckelmann <sven@narfation.org>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
Felix Kaechele <felix@kaechele.ca>
Subject: Re: [PATCH] batman-adv: Don't skb_split skbuffs with frag_list
Date: Sat, 16 Apr 2022 19:26:59 +0200 [thread overview]
Message-ID: <Ylr8YwkBAS+6iozm@lunn.ch> (raw)
In-Reply-To: <2248548.8ZbxvZVH5L@sven-l14>
On Sat, Apr 16, 2022 at 07:17:28PM +0200, Sven Eckelmann wrote:
> On Saturday, 16 April 2022 16:21:19 CEST Andrew Lunn wrote:
> > This is not an area of the kernel i'm very familiar with. But i'm
> > wondering, is this a BATMAN specific problem, or a generic problem?
> > Should the fix be in BATMAN, or the core?
>
> I understand what you mean. But let me cite two places which required to
> operate on parts of the frag lists:
>
> /* If we need update frag list, we are in troubles.
> * Certainly, it is possible to add an offset to skb data,
> * but taking into account that pulling is expected to
> * be very rare operation, it is worth to fight against
> * further bloating skb head and crucify ourselves here instead.
> * Pure masohism, indeed. 8)8)
> */
>
> /* Misery. We are in troubles, going to mincer fragments... */
>
>
> And since I cannot reproduce this here at the moment, I've decided not to
> start with that.
O.K. The BUG_ON() should at least catch other drivers hitting the same
issue, and hopefully a search engine will point to this discussion.
However, i suggest you post the fix to netdev, and see what others
think.
Andrew
next prev parent reply other threads:[~2022-04-16 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 12:24 [PATCH] batman-adv: Don't skb_split skbuffs with frag_list Sven Eckelmann
2022-04-16 14:01 ` Felix Kaechele
2022-04-16 14:21 ` Andrew Lunn
2022-04-16 17:17 ` Sven Eckelmann
2022-04-16 17:26 ` Andrew Lunn [this message]
[not found] ` <165011769041.26690.10778801125078465694@diktynna.open-mesh.org>
2022-04-17 16:07 ` Felix Kaechele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylr8YwkBAS+6iozm@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=felix@kaechele.ca \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).