From: patchwork-bot+netdevbpf@kernel.org
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org, kernel-team@meta.com,
thinker.li@gmail.com, eddyz87@gmail.com
Subject: Re: [PATCH bpf-next] libbpf: better fix for handling nulled-out struct_ops program
Date: Wed, 01 May 2024 17:30:31 +0000 [thread overview]
Message-ID: <171458463154.23034.10864412473237791237.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240501041706.3712608-1-andrii@kernel.org>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Tue, 30 Apr 2024 21:17:06 -0700 you wrote:
> Previous attempt to fix the handling of nulled-out (from skeleton)
> struct_ops program is working well only if struct_ops program is defined
> as non-autoloaded by default (i.e., has SEC("?struct_ops") annotation,
> with question mark).
>
> Unfortunately, that fix is incomplete due to how
> bpf_object_adjust_struct_ops_autoload() is marking referenced or
> non-referenced struct_ops program as autoloaded (or not). Because
> bpf_object_adjust_struct_ops_autoload() is run after
> bpf_map__init_kern_struct_ops() step, which sets program slot to NULL,
> such programs won't be considered "referenced", and so its autoload
> property won't be changed.
>
> [...]
Here is the summary with links:
- [bpf-next] libbpf: better fix for handling nulled-out struct_ops program
https://git.kernel.org/bpf/bpf-next/c/0737df6de946
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-05-01 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 4:17 [PATCH bpf-next] libbpf: better fix for handling nulled-out struct_ops program Andrii Nakryiko
2024-05-01 17:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171458463154.23034.10864412473237791237.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).