From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
bpf@vger.kernel.org, Hari Bathini <hbathini@linux.ibm.com>
Cc: Song Liu <songliubraving@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Martin KaFai Lau <martin.lau@linux.dev>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 1/2] powerpc64/bpf: fix tail calls for PCREL addressing
Date: Wed, 08 May 2024 23:39:45 +1000 [thread overview]
Message-ID: <171517558549.165093.12896481227430118737.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20240502173205.142794-1-hbathini@linux.ibm.com>
On Thu, 02 May 2024 23:02:04 +0530, Hari Bathini wrote:
> With PCREL addressing, there is no kernel TOC. So, it is not setup in
> prologue when PCREL addressing is used. But the number of instructions
> to skip on a tail call was not adjusted accordingly. That resulted in
> not so obvious failures while using tailcalls. 'tailcalls' selftest
> crashed the system with the below call trace:
>
> bpf_test_run+0xe8/0x3cc (unreliable)
> bpf_prog_test_run_skb+0x348/0x778
> __sys_bpf+0xb04/0x2b00
> sys_bpf+0x28/0x38
> system_call_exception+0x168/0x340
> system_call_vectored_common+0x15c/0x2ec
>
> [...]
Applied to powerpc/next.
[1/2] powerpc64/bpf: fix tail calls for PCREL addressing
https://git.kernel.org/powerpc/c/2ecfe59cd7de1f202e9af2516a61fbbf93d0bd4d
[2/2] powerpc/bpf: enable kfunc call
https://git.kernel.org/powerpc/c/61688a82e047a4166436bf2665716cc070572ffa
cheers
prev parent reply other threads:[~2024-05-08 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 17:32 [PATCH v4 1/2] powerpc64/bpf: fix tail calls for PCREL addressing Hari Bathini
2024-05-02 17:32 ` [PATCH v4 2/2] powerpc/bpf: enable kfunc call Hari Bathini
2024-05-07 10:40 ` Naveen N Rao
2024-05-07 10:32 ` [PATCH v4 1/2] powerpc64/bpf: fix tail calls for PCREL addressing Naveen N Rao
2024-05-08 13:39 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171517558549.165093.12896481227430118737.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@iogearbox.net \
--cc=hbathini@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.lau@linux.dev \
--cc=naveen.n.rao@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).