From: Kunwu Chan <chentao@kylinos.cn>
To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org,
kunwu.chan@hotmail.com
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Kunwu Chan <chentao@kylinos.cn>
Subject: [PATCH bpf-next 3/4] selftests/bpf: Add a null pointer check for the load_btf_spec
Date: Wed, 24 Apr 2024 10:04:43 +0800 [thread overview]
Message-ID: <20240424020444.2375773-4-chentao@kylinos.cn> (raw)
In-Reply-To: <20240424020444.2375773-1-chentao@kylinos.cn>
There is a 'malloc' call, which can be unsuccessful.
Add the malloc failure checking to avoid possible null
dereference.
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
tools/testing/selftests/bpf/test_verifier.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
index df04bda1c927..9c80b2943418 100644
--- a/tools/testing/selftests/bpf/test_verifier.c
+++ b/tools/testing/selftests/bpf/test_verifier.c
@@ -762,6 +762,8 @@ static int load_btf_spec(__u32 *types, int types_len,
);
raw_btf = malloc(sizeof(hdr) + types_len + strings_len);
+ if (!raw_btf)
+ return -ENOMEM;
ptr = raw_btf;
memcpy(ptr, &hdr, sizeof(hdr));
--
2.40.1
next prev parent reply other threads:[~2024-04-24 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 2:04 [PATCH bpf-next 0/4] Add some 'malloc' failure checks Kunwu Chan
2024-04-24 2:04 ` [PATCH bpf-next 1/4] selftests/bpf: Add some null pointer checks Kunwu Chan
2024-04-24 9:35 ` Markus Elfring
2024-04-24 2:04 ` [PATCH bpf-next 2/4] selftests/bpf/sockopt: Add a null pointer check for the run_test Kunwu Chan
2024-04-24 10:21 ` Markus Elfring
2024-04-24 2:04 ` Kunwu Chan [this message]
2024-04-24 10:40 ` [PATCH bpf-next 3/4] selftests/bpf: Add a null pointer check for the load_btf_spec Markus Elfring
2024-04-24 2:04 ` [PATCH bpf-next 4/4] selftests/bpf: Add a null pointer check for the serial_test_tp_attach_query Kunwu Chan
2024-04-24 10:48 ` Markus Elfring
2024-05-03 15:47 ` Daniel Borkmann
2024-05-03 15:51 ` Daniel Borkmann
2024-05-10 8:21 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424020444.2375773-4-chentao@kylinos.cn \
--to=chentao@kylinos.cn \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).