From: Andrii Nakryiko <andrii@kernel.org>
To: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org
Cc: andrii@kernel.org, kernel-team@meta.com
Subject: [PATCH bpf-next 0/7] libbpf: further struct_ops fixes and improvements
Date: Mon, 6 May 2024 17:13:28 -0700 [thread overview]
Message-ID: <20240507001335.1445325-1-andrii@kernel.org> (raw)
Fix yet another case of mishandling SEC("struct_ops") programs that were
nulled out programmatically through BPF skeleton by the user.
While at it, add some improvements around detecting and reporting errors,
specifically a common case of declaring SEC("struct_ops") program, but
forgetting to actually make use of it by setting it as a callback
implementation in SEC(".struct_ops") variable (i.e., map) declaration.
A bunch of new selftests are added as well.
Andrii Nakryiko (7):
libbpf: remove unnecessary struct_ops prog validity check
libbpf: handle yet another corner case of nulling out struct_ops
program
selftests/bpf: add another struct_ops callback use case test
libbpf: fix libbpf_strerror_r() handling unknown errors
libbpf: improve early detection of doomed-to-fail BPF program loading
selftests/bpf: validate struct_ops early failure detection logic
selftests/bpf: shorten subtest names for struct_ops_module test
tools/lib/bpf/libbpf.c | 38 ++++++---
tools/lib/bpf/str_error.c | 16 +++-
.../bpf/prog_tests/test_struct_ops_module.c | 78 ++++++++++++++++++-
.../bpf/progs/struct_ops_forgotten_cb.c | 19 +++++
.../bpf/progs/struct_ops_nulled_out_cb.c | 22 ++++++
5 files changed, 156 insertions(+), 17 deletions(-)
create mode 100644 tools/testing/selftests/bpf/progs/struct_ops_forgotten_cb.c
create mode 100644 tools/testing/selftests/bpf/progs/struct_ops_nulled_out_cb.c
--
2.43.0
next reply other threads:[~2024-05-07 0:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 0:13 Andrii Nakryiko [this message]
2024-05-07 0:13 ` [PATCH bpf-next 1/7] libbpf: remove unnecessary struct_ops prog validity check Andrii Nakryiko
2024-05-07 0:13 ` [PATCH bpf-next 2/7] libbpf: handle yet another corner case of nulling out struct_ops program Andrii Nakryiko
2024-05-07 0:13 ` [PATCH bpf-next 3/7] selftests/bpf: add another struct_ops callback use case test Andrii Nakryiko
2024-05-07 0:13 ` [PATCH bpf-next 4/7] libbpf: fix libbpf_strerror_r() handling unknown errors Andrii Nakryiko
2024-05-07 0:13 ` [PATCH bpf-next 5/7] libbpf: improve early detection of doomed-to-fail BPF program loading Andrii Nakryiko
2024-05-07 0:13 ` [PATCH bpf-next 6/7] selftests/bpf: validate struct_ops early failure detection logic Andrii Nakryiko
2024-05-07 0:13 ` [PATCH bpf-next 7/7] selftests/bpf: shorten subtest names for struct_ops_module test Andrii Nakryiko
2024-05-08 0:30 ` [PATCH bpf-next 0/7] libbpf: further struct_ops fixes and improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507001335.1445325-1-andrii@kernel.org \
--to=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).