From: Vadim Fedorenko <vadfed@meta.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Martin KaFai Lau <martin.lau@linux.dev>,
Andrii Nakryiko <andrii@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
Mykola Lysenko <mykolal@fb.com>, Jakub Kicinski <kuba@kernel.org>
Cc: Vadim Fedorenko <vadfed@meta.com>, <bpf@vger.kernel.org>
Subject: [PATCH bpf-next 0/4] bpf: make trusted args nullable
Date: Thu, 9 May 2024 06:40:19 -0700 [thread overview]
Message-ID: <20240509134023.1289303-1-vadfed@meta.com> (raw)
Current verifier checks for the arg to be nullable after checking for
certain pointer types. It prevents programs to pass NULL to kfunc args
even if they are marked as nullable. This patchset adjusts verifier and
changes bpf crypto kfuncs to allow null for IV parameter which is
optional for some ciphers. Benchmark shows ~4% improvements when there
is no need to initialise 0-sized dynptr.
Vadim Fedorenko (4):
bpf: verifier: make kfuncs args nullalble
bpf: crypto: make state and IV dynptr nullable
selftests: bpf: crypto: use NULL instead of 0-sized dynptr
selftests: bpf: crypto: adjust bench to use nullable IV
kernel/bpf/crypto.c | 10 +++++-----
kernel/bpf/verifier.c | 6 +++---
tools/testing/selftests/bpf/progs/crypto_bench.c | 10 ++++------
.../testing/selftests/bpf/progs/crypto_sanity.c | 16 ++++------------
4 files changed, 16 insertions(+), 26 deletions(-)
--
2.43.0
next reply other threads:[~2024-05-09 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 13:40 Vadim Fedorenko [this message]
2024-05-09 13:40 ` [PATCH bpf-next 1/4] bpf: verifier: make kfuncs args nullalble Vadim Fedorenko
2024-05-09 13:40 ` [PATCH bpf-next 2/4] bpf: crypto: make state and IV dynptr nullable Vadim Fedorenko
2024-05-10 3:07 ` kernel test robot
2024-05-09 13:40 ` [PATCH bpf-next 3/4] selftests: bpf: crypto: use NULL instead of 0-sized dynptr Vadim Fedorenko
2024-05-09 13:40 ` [PATCH bpf-next 4/4] selftests: bpf: crypto: adjust bench to use nullable IV Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509134023.1289303-1-vadfed@meta.com \
--to=vadfed@meta.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).