From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Florent Revest <revest@chromium.org>,
linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf <bpf@vger.kernel.org>, Sven Schnelle <svens@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alan Maguire <alan.maguire@oracle.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>, Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH v10 03/36] x86: tracing: Add ftrace_regs definition in the header
Date: Fri, 24 May 2024 10:31:44 -0400 [thread overview]
Message-ID: <20240524103144.4cd800c0@gandalf.local.home> (raw)
In-Reply-To: <20240524103754.1df43a670eeb15bca9df48c7@kernel.org>
On Fri, 24 May 2024 10:37:54 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > >
> > > #ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS
> > > struct ftrace_regs {
> > > + /*
> > > + * On the x86_64, the ftrace_regs saves;
> > > + * rax, rcx, rdx, rdi, rsi, r8, r9, rbp, rip and rsp.
> > > + * Also orig_ax is used for passing direct trampoline address.
> > > + * x86_32 doesn't support ftrace_regs.
> >
> > Should add a comment that if fregs->regs.cs is set, then all of the pt_regs
> > is valid.
>
> But what about rbx and r1*? Only regs->cs should be care for pt_regs?
> Or, did you mean "the ftrace_regs is valid"?
Yeah, on x86_64 ftrace_regs uses regs.cs to denote if it is valid or not:
static __always_inline struct pt_regs *
arch_ftrace_get_regs(struct ftrace_regs *fregs)
{
/* Only when FL_SAVE_REGS is set, cs will be non zero */
if (!fregs->regs.cs)
return NULL;
return &fregs->regs;
}
-- Steve
next prev parent reply other threads:[~2024-05-24 14:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 14:08 [PATCH v10 00/36] tracing: fprobe: function_graph: Multi-function graph and fprobe on fgraph Masami Hiramatsu (Google)
2024-05-07 14:08 ` [PATCH v10 01/36] tracing: Add a comment about ftrace_regs definition Masami Hiramatsu (Google)
2024-05-23 23:10 ` Steven Rostedt
2024-05-24 1:09 ` Masami Hiramatsu
2024-05-07 14:08 ` [PATCH v10 02/36] tracing: Rename ftrace_regs_return_value to ftrace_regs_get_return_value Masami Hiramatsu (Google)
2024-05-07 14:08 ` [PATCH v10 03/36] x86: tracing: Add ftrace_regs definition in the header Masami Hiramatsu (Google)
2024-05-23 23:14 ` Steven Rostedt
2024-05-24 1:37 ` Masami Hiramatsu
2024-05-24 14:31 ` Steven Rostedt [this message]
2024-05-07 14:08 ` [PATCH v10 04/36] function_graph: Convert ret_stack to a series of longs Masami Hiramatsu (Google)
2024-05-07 14:08 ` [PATCH v10 05/36] fgraph: Use BUILD_BUG_ON() to make sure we have structures divisible by long Masami Hiramatsu (Google)
2024-05-07 14:09 ` [PATCH v10 06/36] function_graph: Add an array structure that will allow multiple callbacks Masami Hiramatsu (Google)
2024-05-07 14:09 ` [PATCH v10 07/36] function_graph: Allow multiple users to attach to function graph Masami Hiramatsu (Google)
2024-05-25 1:32 ` Steven Rostedt
2024-05-25 9:44 ` Masami Hiramatsu
2024-05-07 14:09 ` [PATCH v10 08/36] function_graph: Remove logic around ftrace_graph_entry and return Masami Hiramatsu (Google)
2024-05-07 14:09 ` [PATCH v10 09/36] ftrace/function_graph: Pass fgraph_ops to function graph callbacks Masami Hiramatsu (Google)
2024-05-07 14:09 ` [PATCH v10 10/36] ftrace: Allow function_graph tracer to be enabled in instances Masami Hiramatsu (Google)
2024-05-07 14:10 ` [PATCH v10 11/36] ftrace: Allow ftrace startup flags exist without dynamic ftrace Masami Hiramatsu (Google)
2024-05-07 14:10 ` [PATCH v10 12/36] function_graph: Have the instances use their own ftrace_ops for filtering Masami Hiramatsu (Google)
2024-05-07 14:10 ` [PATCH v10 13/36] function_graph: Use a simple LRU for fgraph_array index number Masami Hiramatsu (Google)
2024-05-07 14:10 ` [PATCH v10 14/36] function_graph: Add "task variables" per task for fgraph_ops Masami Hiramatsu (Google)
2024-05-07 14:10 ` [PATCH v10 15/36] function_graph: Move set_graph_function tests to shadow stack global var Masami Hiramatsu (Google)
2024-05-07 14:11 ` [PATCH v10 16/36] function_graph: Move graph depth stored data " Masami Hiramatsu (Google)
2024-05-07 14:11 ` [PATCH v10 17/36] function_graph: Move graph notrace bit " Masami Hiramatsu (Google)
2024-05-07 14:11 ` [PATCH v10 18/36] function_graph: Implement fgraph_reserve_data() and fgraph_retrieve_data() Masami Hiramatsu (Google)
2024-05-07 14:11 ` [PATCH v10 19/36] function_graph: Add selftest for passing local variables Masami Hiramatsu (Google)
2024-05-07 14:11 ` [PATCH v10 20/36] ftrace: Add multiple fgraph storage selftest Masami Hiramatsu (Google)
2024-05-07 14:12 ` [PATCH v10 21/36] function_graph: Pass ftrace_regs to entryfunc Masami Hiramatsu (Google)
2024-05-07 14:12 ` [PATCH v10 22/36] function_graph: Replace fgraph_ret_regs with ftrace_regs Masami Hiramatsu (Google)
2024-05-07 14:12 ` [PATCH v10 23/36] function_graph: Pass ftrace_regs to retfunc Masami Hiramatsu (Google)
2024-05-07 14:12 ` [PATCH v10 24/36] fprobe: Use ftrace_regs in fprobe entry handler Masami Hiramatsu (Google)
2024-05-07 14:12 ` [PATCH v10 25/36] fprobe: Use ftrace_regs in fprobe exit handler Masami Hiramatsu (Google)
2024-05-07 14:13 ` [PATCH v10 26/36] tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs Masami Hiramatsu (Google)
2024-05-07 14:13 ` [PATCH v10 27/36] tracing: Add ftrace_fill_perf_regs() for perf event Masami Hiramatsu (Google)
2024-05-07 14:13 ` [PATCH v10 28/36] tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS Masami Hiramatsu (Google)
2024-05-07 14:13 ` [PATCH v10 29/36] bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled Masami Hiramatsu (Google)
2024-05-07 14:13 ` [PATCH v10 30/36] ftrace: Add CONFIG_HAVE_FTRACE_GRAPH_FUNC Masami Hiramatsu (Google)
2024-05-07 14:14 ` [PATCH v10 31/36] fprobe: Rewrite fprobe on function-graph tracer Masami Hiramatsu (Google)
2024-05-07 14:14 ` [PATCH v10 32/36] tracing/fprobe: Remove nr_maxactive from fprobe Masami Hiramatsu (Google)
2024-05-07 14:14 ` [PATCH v10 33/36] selftests: ftrace: Remove obsolate maxactive syntax check Masami Hiramatsu (Google)
2024-05-07 14:14 ` [PATCH v10 34/36] selftests/ftrace: Add a test case for repeating register/unregister fprobe Masami Hiramatsu (Google)
2024-05-07 14:14 ` [PATCH v10 35/36] Documentation: probes: Update fprobe on function-graph tracer Masami Hiramatsu (Google)
2024-05-07 14:15 ` [PATCH v10 36/36] fgraph: Skip recording calltime/rettime if it is not nneeded Masami Hiramatsu (Google)
2024-05-24 22:41 ` [PATCH v10 00/36] tracing: fprobe: function_graph: Multi-function graph and fprobe on fgraph Steven Rostedt
2024-05-25 9:48 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524103144.4cd800c0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=guoren@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=revest@chromium.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).