From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT"
Date: Tue, 7 May 2024 13:19:53 -0700 [thread overview]
Message-ID: <CAEf4BzZ98z5eQmE42RKn2=TdVTqVjxkOehc-OydPd2PQ+fgmvw@mail.gmail.com> (raw)
In-Reply-To: <20240501112059.1348423-1-colin.i.king@gmail.com>
On Wed, May 1, 2024 at 4:21 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There are two spelling mistakes in .descr literal strings. Fix them.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
This doesn't apply cleanly onto bpf-next/master, unfortunately. Can
you please rebase and resend?
pw-bot: cr
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt.c b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> index eaac83a7f388..ecf5a7a047a4 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockopt.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> @@ -933,7 +933,7 @@ static struct sockopt_test {
> /* ==================== prog_type ==================== */
>
> {
> - .descr = "can attach only BPF_CGROUP_SETSOCKOP",
> + .descr = "can attach only BPF_CGROUP_SETSOCKOPT",
> .insns = {
> /* return 1 */
> BPF_MOV64_IMM(BPF_REG_0, 1),
> @@ -947,7 +947,7 @@ static struct sockopt_test {
> },
>
> {
> - .descr = "can attach only BPF_CGROUP_GETSOCKOP",
> + .descr = "can attach only BPF_CGROUP_GETSOCKOPT",
> .insns = {
> /* return 1 */
> BPF_MOV64_IMM(BPF_REG_0, 1),
> --
> 2.39.2
>
prev parent reply other threads:[~2024-05-07 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 11:20 [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT" Colin Ian King
2024-05-07 20:19 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzZ98z5eQmE42RKn2=TdVTqVjxkOehc-OydPd2PQ+fgmvw@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=colin.i.king@gmail.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).