From: Daniel Xu <dxu@dxuuu.xyz>
To: acme@kernel.org, jolsa@kernel.org, quentin@isovalent.com,
alan.maguire@oracle.com, eddyz87@gmail.com
Cc: andrii.nakryiko@gmail.com, ast@kernel.org, daniel@iogearbox.net,
bpf@vger.kernel.org
Subject: [PATCH dwarves v8 0/3] pahole: Inject kfunc decl tags into BTF
Date: Thu, 25 Apr 2024 18:28:38 -0600 [thread overview]
Message-ID: <cover.1714091281.git.dxu@dxuuu.xyz> (raw)
This patchset teaches pahole to parse symbols in .BTF_ids section in
vmlinux and discover exported kfuncs. Pahole then takes the list of
kfuncs and injects a BTF_KIND_DECL_TAG for each kfunc.
Example of encoding:
$ bpftool btf dump file .tmp_vmlinux.btf | rg "DECL_TAG 'bpf_kfunc'" | wc -l
121
$ bpftool btf dump file .tmp_vmlinux.btf | rg 56337
[56337] FUNC 'bpf_ct_change_timeout' type_id=56336 linkage=static
[127861] DECL_TAG 'bpf_kfunc' type_id=56337 component_idx=-1
This enables downstream users and tools to dynamically discover which
kfuncs are available on a system by parsing vmlinux or module BTF, both
available in /sys/kernel/btf.
This feature is enabled with --btf_features=decl_tag,decl_tag_kfuncs.
=== Changelog ===
Changes from v7:
* Fix/support detached BTF encoding
Changes from v6:
* Rebase and add decl_tag_kfuncs as default feature
Changes from v5:
* Add gobuffer__sort() helper
* Use strstarts() instead of strncmp()
* Use uint64_t instead of size_t
* Add clarifying comments for get_func_name()
Changes from v4:
* Update man page with decl_tag_kfuncs feature
* Fix release mode build warnings
* Add elf_getshrstrndx() error checking
* Disable tagging if decl_tag feature is off
* Fix malformed func name handling
Changes from v3:
* Guard kfunc tagging behind feature flag
* Use struct btf_id_set8 definition
* Remove unnecessary member from btf_encoder
* Fix code styling
Changes from v2:
* More reliably detect kfunc membership in set8 by tracking set addr ranges
* Rename some variables/functions to be more clear about kfunc vs func
Changes from v1:
* Fix resource leaks
* Fix callee -> caller typo
* Rename btf_decl_tag from kfunc -> bpf_kfunc
* Only grab btf_id_set funcs tagged kfunc
* Presort btf func list
Daniel Xu (3):
pahole: Save input filename separate from output
pahole: Add --btf_feature=decl_tag_kfuncs feature
pahole: Inject kfunc decl tags into BTF
btf_encoder.c | 377 +++++++++++++++++++++++++++++++++++++++++++++
dwarves.h | 1 +
man-pages/pahole.1 | 1 +
pahole.c | 1 +
4 files changed, 380 insertions(+)
--
2.44.0
next reply other threads:[~2024-04-26 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 0:28 Daniel Xu [this message]
2024-04-26 0:28 ` [PATCH dwarves v8 1/3] pahole: Save input filename separate from output Daniel Xu
2024-04-26 0:28 ` [PATCH dwarves v8 2/3] pahole: Add --btf_feature=decl_tag_kfuncs feature Daniel Xu
2024-04-26 0:28 ` [PATCH dwarves v8 3/3] pahole: Inject kfunc decl tags into BTF Daniel Xu
2024-04-26 19:47 ` Eduard Zingerman
2024-04-26 20:55 ` Eduard Zingerman
2024-04-26 23:47 ` Eduard Zingerman
2024-04-29 22:38 ` Daniel Xu
2024-04-26 9:08 ` [PATCH dwarves v8 0/3] " Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1714091281.git.dxu@dxuuu.xyz \
--to=dxu@dxuuu.xyz \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=jolsa@kernel.org \
--cc=quentin@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).