BPF Archive mirror
 help / color / mirror / Atom feed

From: Puranjay Mohan <puranjay@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
	bpf@vger.kernel.org
Subject: On inlining more helpers in the JITs or the verifier
Date: Thu, 02 May 2024 17:37:01 +0000	[thread overview]
Message-ID: <mb61p1q6k869u.fsf@kernel.org> (raw)


Hi Everyone,

While working on inlining bpf_get_smp_processor_id() in the ARM64 and
RISCV JITs, I realized that these archs allow such optimizations because
they keep some information like the per-cpu offset or the pointer to the
task_struct in special system registers.

So, I went through the list of all BPF helpers and made a list of
helpers that we can inline in these JITs to make their usage much more
optimized:

I. ARM64 and RISC-V specific optimzations if inlined:

    A) Because pointer to tast_struct is available in a register:
        1. bpf_get_current_pid_tgid()
        2. bpf_get_current_task()
        3. bpf_set_retval()
        4. bpf_get_retval()
        5. bpf_task_pt_regs()
        6. bpf_get_attach_cookie()
    
    B) Because per_cpu offset is available in a register:
        1. bpf_this_cpu_ptr()
        2. bpf_get_numa_node_id()

        These can be inlined in the verifier too using the newly
        introduced per-cpu instruction.

II. These are very basic writes, can be inlined in the verifier or the JIT:
    1. bpf_msg_apply_bytes()
    2. bpf_msg_cork_bytes()
    3. bpf_set_hash_invalid()

I will first try to inline all these in the ARM64 JIT and see the
performance improvement. I am not sure what would be the best way to
benchmark all of this inlining.

Andrii, can you suggest something for the benchmarking?

Looking forward to your thoughts on this.

Thanks,
Puranjay

next             reply	other threads:[~2024-05-02 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 17:37 Puranjay Mohan [this message]
2024-05-02 19:19 ` On inlining more helpers in the JITs or the verifier Puranjay Mohan
2024-05-02 21:22 ` Andrii Nakryiko
2024-05-03 16:04   ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mb61p1q6k869u.fsf@kernel.org \
    --to=puranjay@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).