From: David Gibson <david@gibson.dropbear.id.au>
To: Cody P Schafer <dev@codyps.com>
Cc: ccan@lists.ozlabs.org
Subject: Re: [PATCH v4 0/4] mem: extend with a few additional helpers similar to existing string-only functions
Date: Mon, 7 Sep 2015 00:24:48 +1000 [thread overview]
Message-ID: <20150906142448.GE6537@voom.redhat.com> (raw)
In-Reply-To: <1441502466-4754-1-git-send-email-dev@codyps.com>
[-- Attachment #1.1: Type: text/plain, Size: 959 bytes --]
On Sat, Sep 05, 2015 at 09:21:02PM -0400, Cody P Schafer wrote:
> since v3:
>
> - fix memeq() return value
> - add memends_str() helper
>
> since v2:
>
> - switch all the macros to static inline to avoid multiple evaluations of args
> - add patch adding PURE_FUNCTION attributes
>
> since v1:
>
> - drop a patch that David pulled in
> - add extra macro parens
> - add blank lines after defintions
> - covert memcchr's while loop to a for.
> - change examples for mempbrkm and mempbrk to use '\0' in places
> - fix spelling
> - use memeq() even where we know the mem lengths are equal in memstarts()
> - add a reviewed-by to the 2nd patch, no other changes to that patch.
Looks good, I've applied this to the repository.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2015-09-06 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 1:21 [PATCH v4 0/4] mem: extend with a few additional helpers similar to existing string-only functions Cody P Schafer
2015-09-06 1:21 ` [PATCH v4 1/4] mem: add mem helper functions Cody P Schafer
2015-09-06 1:21 ` [PATCH v4 2/4] bytestring: use newly added mem helpers Cody P Schafer
2015-09-06 1:21 ` [PATCH v4 3/4] mem: mark all functions as PURE Cody P Schafer
2015-09-06 1:21 ` [PATCH v4 4/4] mem: add memends_str() helper for symmetry Cody P Schafer
2015-09-06 14:24 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906142448.GE6537@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=dev@codyps.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).