From: David Gibson <david@gibson.dropbear.id.au>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: ccan@lists.ozlabs.org
Subject: Re: [PATCH] strgrp: Fix compile errors in example
Date: Tue, 15 Sep 2015 09:55:36 +1000 [thread overview]
Message-ID: <20150914235536.GQ2547@voom.fritz.box> (raw)
In-Reply-To: <1442232882.16095.17.camel@aj.id.au>
[-- Attachment #1.1: Type: text/plain, Size: 1438 bytes --]
On Mon, Sep 14, 2015 at 09:44:42PM +0930, Andrew Jeffery wrote:
> Hi David,
>
> On Mon, 2015-09-14 at 21:25 +1000, David Gibson wrote:
> > Commit 63f13d6 "strgrp: Tidy up kerneldoc in _info" introduced some
> > compile
> > errors into the example in strgrp/_info. This fixes them.
>
> Ah damn :( Apologies for that!
>
> I was hacking around with `make webpages` to check the rendering and
> clearly forgot to run `make check`. I'll make sure to configure Travis
> CI.
Well, make check is pretty slow since it checks the whole repo.
Running ccanlint individually on the module you're working on is
generally a good idea though.
> Separately, I had tried to post the initial patch to the mailing list
> to get some feedback but `git send-email` was failing to send it, not
> sure why. I figured that as the original patch only really appeared on
> Rusty's radar that posting just the "documentation" fixup for review
> might've lacked context, but clearly I should've done so (and clearly
> it was more than "just" documentation).
TBH, I doubt I would have spotted this breakage on inspection so I
don't know that posting for review would have helped.
> Thanks for cleaning up after me :/
No problem :)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2015-09-15 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 11:25 [PATCH] strgrp: Fix compile errors in example David Gibson
2015-09-14 12:14 ` Andrew Jeffery
2015-09-14 23:55 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914235536.GQ2547@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=andrew@aj.id.au \
--cc=ccan@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).