From: David Gibson <david@gibson.dropbear.id.au>
To: Eric Wong <normalperson@yhbt.net>
Cc: ccan@lists.ozlabs.org
Subject: Re: [PATCH] timer: remove unnecessary dependency on likely
Date: Tue, 12 Jun 2018 12:36:32 +1000 [thread overview]
Message-ID: <20180612023632.GW2737@umbus.fritz.box> (raw)
In-Reply-To: <20180608024542.dm4s6s4flmsi3jqm@dcvr>
[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]
On Fri, Jun 08, 2018 at 02:45:42AM +0000, Eric Wong wrote:
> I don't see likely/unlikely being used by ccan/timer or any of its
> dependencies right now.
>
> Running `tools/ccanlint/ccanlint ccan/timer' reveals no regressions
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
Applied, thanks.
> ---
> ccan/timer/_info | 1 -
> ccan/timer/timer.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/ccan/timer/_info b/ccan/timer/_info
> index 9f5ec7a2..d76a7e67 100644
> --- a/ccan/timer/_info
> +++ b/ccan/timer/_info
> @@ -70,7 +70,6 @@ int main(int argc, char *argv[])
> if (strcmp(argv[1], "depends") == 0) {
> printf("ccan/array_size\n");
> printf("ccan/ilog\n");
> - printf("ccan/likely\n");
> printf("ccan/list\n");
> printf("ccan/time\n");
> return 0;
> diff --git a/ccan/timer/timer.c b/ccan/timer/timer.c
> index 91f46393..84d7aa14 100644
> --- a/ccan/timer/timer.c
> +++ b/ccan/timer/timer.c
> @@ -2,7 +2,6 @@
> #include <ccan/timer/timer.h>
> #include <ccan/array_size/array_size.h>
> #include <ccan/ilog/ilog.h>
> -#include <ccan/likely/likely.h>
> #include <stdlib.h>
> #include <stdio.h>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2018-06-12 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 2:45 [PATCH] timer: remove unnecessary dependency on likely Eric Wong
2018-06-12 2:36 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612023632.GW2737@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).