From: David Gibson <david@gibson.dropbear.id.au>
To: Ian Zimmerman <itz@very.loosely.org>
Cc: ccan@lists.ozlabs.org
Subject: Re: make check fails in coroutine module
Date: Wed, 27 Mar 2019 23:08:54 +1100 [thread overview]
Message-ID: <20190327120854.GM8544@umbus.fritz.box> (raw)
In-Reply-To: <20190326195806.zpxnolrlw243k72y@matica.foolinux.mooo.com>
[-- Attachment #1.1: Type: text/plain, Size: 1501 bytes --]
On Tue, Mar 26, 2019 at 12:58:06PM -0700, Ian Zimmerman wrote:
> On 2019-03-26 15:31, David Gibson wrote:
>
> > > ... more (use -vv to see them all)
> > > coroutine: Total score: 35/43 FAIL!
> > > make: *** [Makefile:78: ccan/coroutine/.ok] Error 1
> > >
> > > Perhaps it is relevant that the configurator check causing the
> > > segfault - as discussed in the other thread - is
> > > HAVE_POINTER_SAFE_MAKECONTEXT which, I believe, is only used by
> > > coroutine module.
>
> > Urgh, yeah, it's broken. Finding time to debug and fix it is proving
> > difficult.
>
> Ok, I understand that perfectly. But I'd like to contrbiute to ccan,
> and I'll only feel comfortable doing that when I have a clean test suite
> to start with. What would you suggest as a workaround? Maybe a local
> branch with the coroutine module removed?
That would work, assuming you don't want the coroutine module or
anything it relies on.
But, I'm not sure that's the right approach. ccan isn't really
intended as a monolithic project, each module should be more or less
independent, with the check everything at the top level being just a
convenience.
If you're looking to contribute you can run ccanlint to build and test
a single module (and its dependencies) and that should suffice.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2019-03-27 21:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 22:39 make check fails in coroutine module Ian Zimmerman
2019-03-26 4:31 ` David Gibson
2019-03-26 19:58 ` Ian Zimmerman
2019-03-27 12:08 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327120854.GM8544@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=itz@very.loosely.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).