From: Rusty Russell <rusty@rustcorp.com.au>
To: David Gibson <david@gibson.dropbear.id.au>, ccan@lists.ozlabs.org
Subject: Re: bitmap/tal again
Date: Sat, 16 Sep 2017 13:08:30 +0930 [thread overview]
Message-ID: <87poarnwi1.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20170915083225.GL5250@umbus.fritz.box>
David Gibson <david@gibson.dropbear.id.au> writes:
> On Fri, Sep 15, 2017 at 01:03:55AM -0700, Ian Zimmerman wrote:
>> Hi, so I'd like to add the bitmap/tal submodule as discussed here:
>>
>> https://github.com/rustyrussell/ccan/pull/60
>>
>> but I'm not familiar enough with ccan dependency declarations yet :(
>>
>> 1. Should the dependency on tal be declared in bitmap/_info or in
>> bitmap/tal/_info? The latter seems more natural, but for some reason
>> the final pull request on github shows the former. I don't know if
>> that's something I did and Rusty didn't correct, or something that Rusty
>> did. (I also don't quite understand github, ARGH!)
>
> In bitmap/tal/_info, definitely. Putting it in bitmap/_info will
> change the dependencies of the base bitmap module, not your new
> submodule.
>
>> 2. Does bitmap/tal need to declare dependency on bitmap, or is that
>> automatic? Or maybe the other way? I tried to look at other submodules
>> in the tree, but there are only a few and none that quite match the
>> relationship between this proposed pair.
>
> Looking at ccan/tal/str, looks like the surrounding module should be
> explicitly listed in dependencies.
Indeed. There's no implied dependency between a submodule and parent
module. Generally the submodule will depend on the parent module, but
we can also imagine a foo module which depends on a foo/lowlevel module.
Cheers,
Rusty.
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2017-09-17 3:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 8:03 bitmap/tal again Ian Zimmerman
2017-09-15 8:32 ` David Gibson
2017-09-16 3:38 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poarnwi1.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ccan@lists.ozlabs.org \
--cc=david@gibson.dropbear.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).