From: Damien Grassart <damien@grassart.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: ccan@lists.ozlabs.org
Subject: Re: [PATCH 2/2] darray: Evaluate the index parameter only once in darray_remove()
Date: Sun, 27 Aug 2017 22:11:14 +0200 [thread overview]
Message-ID: <CADZuF1n3WzKPYSfcwJT7mYHLmwskHKFv78JU6K_qhsRE+sR1tQ@mail.gmail.com> (raw)
In-Reply-To: <20170827025853.GO2772@umbus.fritz.box>
[-- Attachment #1.1: Type: text/plain, Size: 2039 bytes --]
Oops sorry I'll resend with the Signed-off-by.
For the underscores, I was trying to keep the same style as the rest of the
code, but I can resend a patch with all the "__identifiers" switched to
"identifiers__"?
On Sun, Aug 27, 2017 at 4:58 AM, David Gibson <david@gibson.dropbear.id.au>
wrote:
> On Sat, Aug 26, 2017 at 06:26:52PM +0200, Damien Grassart wrote:
> > To be consistent with the rest of the code, the index paramater should
> > not be evaluated multiple times. Calling this with rand() % arr.size
> > would otherwise generally segfault.
> > ---
> > ccan/darray/darray.h | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Looks like a definite improvement, but I need a Signed-off-by line in
> order to apply it.
>
> Also.. identifiers starting with _ are technically reserved for system
> use. You'd probably get away with it, but it's best to avoid them. I
> usually put _ after the name instead for this sort of thing.
>
> >
> > diff --git a/ccan/darray/darray.h b/ccan/darray/darray.h
> > index 8d47645b..6dd34f08 100644
> > --- a/ccan/darray/darray.h
> > +++ b/ccan/darray/darray.h
> > @@ -224,8 +224,9 @@ typedef darray(unsigned long) darray_ulong;
> > #define darray_pop_check(arr) ((arr).size ? darray_pop(arr) : NULL)
> > /* Warning, slow: Requires copying all elements after removed item. */
> > #define darray_remove(arr, index) do { \
> > - if (index < arr.size-1) \
> > - memmove(&(arr).item[index], &(arr).item[index+1],
> ((arr).size-1-index)*sizeof(*(arr).item)); \
> > + size_t __index = index; \
> > + if (__index < arr.size-1) \
> > + memmove(&(arr).item[__index], &(arr).item[__index+1],
> ((arr).size-1-__index)*sizeof(*(arr).item)); \
> > (arr).size--; \
> > } while(0)
> >
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
>
[-- Attachment #1.2: Type: text/html, Size: 2952 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2017-08-27 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 16:26 [PATCH 2/2] darray: Evaluate the index parameter only once in darray_remove() Damien Grassart
2017-08-27 2:58 ` David Gibson
2017-08-27 20:11 ` Damien Grassart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADZuF1n3WzKPYSfcwJT7mYHLmwskHKFv78JU6K_qhsRE+sR1tQ@mail.gmail.com \
--to=damien@grassart.com \
--cc=ccan@lists.ozlabs.org \
--cc=david@gibson.dropbear.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).