From: Mario Limonciello <mario.limonciello@amd.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Benson Leung" <bleung@chromium.org>,
"Lee Jones" <lee@kernel.org>
Cc: Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
chrome-platform@lists.linux.dev,
Dustin Howett <dustin@howett.net>,
Moritz Fischer <mdf@kernel.org>
Subject: Re: [PATCH v2 0/2] ChromeOS Embedded controller hwmon driver
Date: Tue, 7 May 2024 14:03:47 -0500 [thread overview]
Message-ID: <65d58c4a-46e4-4012-8342-ee93b12dd68f@amd.com> (raw)
In-Reply-To: <20240507-cros_ec-hwmon-v2-0-1222c5fca0f7@weissschuh.net>
On 5/7/2024 11:29, Thomas Weißschuh wrote:
> Add a hwmon driver that reports fan and temperature readings from the
> ChromeOS Embedded controller.
>
> There was an earlier effort in 2017 to add such a driver [0], but there
> was no followup after v1.
> The new driver is complete reimplementation based on newer APIs and with
> more features (temp sensor names).
>
> It only works on LPC-connected ECs, as only those implement direct
> memory-map access.
> For other busses the data would need to be read with a command.
> Adding some helpers was discussed in the previous patchset [1].
>
> The EC protocols also support reading and writing fan curves but that is
> not implemented.
>
> Tested on a Framework 13 AMD, Firmware 3.05.
>
> [0] https://lore.kernel.org/all/1491602410-31518-1-git-send-email-moritz.fischer@ettus.com/
> [1] https://lore.kernel.org/all/ac61bfca-bfa0-143b-c9ca-365b8026ce8d@roeck-us.net/
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Changes in v2:
> - drop unnecessary range checks (Guenter)
> - only validate thermal_version during probing
> - reorder some variable declarations
> - validate thermal_version directly in cros_ec_hwmon_probe (Mario)
> - drop return value from probe_temp_sensors as it can't fail anymore
> - fail with -ENODEV if cmd_readmem is missing to avoid spurious warnings
> - Link to v1: https://lore.kernel.org/r/20240507-cros_ec-hwmon-v1-0-2c47c5ce8e85@weissschuh.net
>
> ---
> Thomas Weißschuh (2):
> hwmon: add ChromeOS EC driver
> mfd: cros_ec: Register hardware monitoring subdevice
>
> Documentation/hwmon/cros_ec_hwmon.rst | 26 ++++
> Documentation/hwmon/index.rst | 1 +
> MAINTAINERS | 8 +
> drivers/hwmon/Kconfig | 11 ++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/cros_ec_hwmon.c | 269 ++++++++++++++++++++++++++++++++++
> drivers/mfd/cros_ec_dev.c | 1 +
> 7 files changed, 317 insertions(+)
> ---
> base-commit: 2fbe479c0024e1c6b992184a799055e19932aa48
> change-id: 20240506-cros_ec-hwmon-24634b07cf6f
>
> Best regards,
That was fast! The series looks good to me, thanks.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
prev parent reply other threads:[~2024-05-07 19:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 16:29 [PATCH v2 0/2] ChromeOS Embedded controller hwmon driver Thomas Weißschuh
2024-05-07 16:29 ` [PATCH v2 1/2] hwmon: add ChromeOS EC driver Thomas Weißschuh
2024-05-07 20:55 ` Guenter Roeck
2024-05-07 21:59 ` Thomas Weißschuh
2024-05-24 23:13 ` Stephen Horvath
2024-05-27 19:24 ` Thomas Weißschuh
2024-05-28 0:15 ` Stephen Horvath
2024-05-28 15:50 ` Guenter Roeck
2024-05-28 16:15 ` Thomas Weißschuh
2024-05-28 23:29 ` Guenter Roeck
2024-05-29 0:58 ` Stephen Horvath
2024-05-29 6:23 ` Thomas Weißschuh
2024-05-29 7:40 ` Stephen Horvath
2024-05-07 16:29 ` [PATCH v2 2/2] mfd: cros_ec: Register hardware monitoring subdevice Thomas Weißschuh
2024-05-07 19:03 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65d58c4a-46e4-4012-8342-ee93b12dd68f@amd.com \
--to=mario.limonciello@amd.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=jdelvare@suse.com \
--cc=lee@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).