From: Mark Hasemeyer <markhas@chromium.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Raul Rangel <rrangel@chromium.org>,
Benson Leung <bleung@chromium.org>,
Bhanu Prakash Maiya <bhanumaiya@chromium.org>,
Chen-Yu Tsai <wenst@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
Rob Barnes <robbarnes@google.com>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v1 6/6] platform/chrome: cros_ec: Use PM subsystem to manage wakeirq
Date: Fri, 15 Dec 2023 14:02:04 -0700 [thread overview]
Message-ID: <CANg-bXApLtwuk+B3=F4b0M_xJ06x6kn2Owbb0RC6Rdpcma4_Ow@mail.gmail.com> (raw)
In-Reply-To: <ZXpx9esFooSgq11q@google.com>
> It looks to me the patch combines multiple changes. Please separate them into
> smaller pieces for reviewing easier.
Unfortunately, I don't see an easy way to break up this commit without
breaking EC wake functionality along the way.
> Another confusing about the patch subject: "6/6"? Is it a series? I don't
> see the cover letter.
Sorry about that! I'll make sure to add a cover letter and CC you on
the next series version.
prev parent reply other threads:[~2023-12-15 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid>
2023-12-13 18:00 ` [PATCH v1 6/6] platform/chrome: cros_ec: Use PM subsystem to manage wakeirq Mark Hasemeyer
2023-12-14 3:09 ` Tzung-Bi Shih
2023-12-15 21:02 ` Mark Hasemeyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANg-bXApLtwuk+B3=F4b0M_xJ06x6kn2Owbb0RC6Rdpcma4_Ow@mail.gmail.com' \
--to=markhas@chromium.org \
--cc=bhanumaiya@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=robbarnes@google.com \
--cc=rrangel@chromium.org \
--cc=tzungbi@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).