From: "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Prashant Malani <pmalani@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"chrome-platform@lists.linux.dev"
<chrome-platform@lists.linux.dev>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"bleung@chromium.org" <bleung@chromium.org>
Subject: RE: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support
Date: Mon, 18 Sep 2023 16:19:24 +0000 [thread overview]
Message-ID: <MWHPR11MB00487D601B4CDD3A387BA0E3A9FBA@MWHPR11MB0048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ZQgEbXDNZ+Ap/HiV@kuha.fi.intel.com>
Hi Heikki,
Thank you for the feedback.
> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Sent: Monday, September 18, 2023 1:04 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@intel.com>
> Cc: Prashant Malani <pmalani@chromium.org>; linux-kernel@vger.kernel.org;
> linux-usb@vger.kernel.org; chrome-platform@lists.linux.dev;
> andriy.shevchenko@linux.intel.com; bleung@chromium.org
> Subject: Re: [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport
> Alternatemode 2.1 Support
>
> On Fri, Sep 15, 2023 at 04:01:44PM +0000, Patel, Utkarsh H wrote:
>
> > > > b057250704e8..3a747938cdab 100644
> > > > --- a/include/linux/usb/pd_vdo.h
> > > > +++ b/include/linux/usb/pd_vdo.h
> > > > @@ -376,6 +376,7 @@
> > > > | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5 \
> > > > | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7))
> > > >
> > > > +#define VDO_TYPEC_CABLE_SPEED(vdo) ((vdo) & 0x7)
> > >
> > > I would suggest putting this header modification in a separate
> > > patch; if for some reason we have to revert the Chrome part of the
> > > change, then we won't rip this part out too (some other driver down
> > > the road may use the macro and would break if it were to be
> > > removed). But I'll leave it to Heikki to determine whether that is preferred.
> > >
> > Heikki, What's your preference here?
>
> I think separate patch for this like Prashant said.
I will add and re-send the removed [PATCH v2 3/5] in the next version.
Sincerely,
Utkarsh Patel.
next prev parent reply other threads:[~2023-09-18 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 0:57 [PATCH v3 0/4] Displayport Alternate Mode 2.1 Support Utkarsh Patel
2023-09-12 0:57 ` [PATCH v3 1/4] usb: typec: Add " Utkarsh Patel
2023-09-12 0:57 ` [PATCH v3 2/4] usb: typec: Add Active or Passive cable defination to cable discover mode VDO Utkarsh Patel
2023-09-12 0:57 ` [PATCH v3 3/4] platform/chrome: cros_ec_typec: Add Displayport Alternatemode 2.1 Support Utkarsh Patel
2023-09-12 1:17 ` Prashant Malani
2023-09-15 16:01 ` Patel, Utkarsh H
2023-09-18 8:03 ` Heikki Krogerus
2023-09-18 16:19 ` Patel, Utkarsh H [this message]
2023-09-12 0:57 ` [PATCH v3 4/4] usb: typec: intel_pmc_mux: Configure Displayport Alternate mode 2.1 Utkarsh Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB00487D601B4CDD3A387BA0E3A9FBA@MWHPR11MB0048.namprd11.prod.outlook.com \
--to=utkarsh.h.patel@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).