From: Johan Hovold <johan@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-bluetooth@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
greybus-dev@lists.linaro.org, linux-iio@vger.kernel.org,
netdev@vger.kernel.org, chrome-platform@lists.linux.dev,
platform-driver-x86@vger.kernel.org,
linux-serial@vger.kernel.org, linux-sound@vger.kernel.org,
"Francesco Dolcini" <francesco.dolcini@toradex.com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Alex Elder" <elder@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lee Jones" <lee@kernel.org>, "Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Benson Leung" <bleung@chromium.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Rob Herring" <robh@kernel.org>
Subject: Re: [PATCH v1] treewide, serdev: change receive_buf() return type to size_t
Date: Mon, 18 Dec 2023 09:35:04 +0100 [thread overview]
Message-ID: <ZYAEOCMwZGMNvpNX@hovoldconsulting.com> (raw)
In-Reply-To: <ZXyH1Zv3Pxd6S3ag@francesco-nb.int.toradex.com>
On Fri, Dec 15, 2023 at 06:07:33PM +0100, Francesco Dolcini wrote:
> On Fri, Dec 15, 2023 at 05:18:52PM +0100, Johan Hovold wrote:
> > On Fri, Dec 15, 2023 at 02:55:59PM +0100, Francesco Dolcini wrote:
> > > To me the change is correct, with that said probably this should have
> > > been explicitly mentioned in the commit message or a separate
> > > preparation patch.
> >
> > It's a separate change and should not be hidden away in a tree-wide
> > change that goes through a different maintainer.
> >
> > Please drop this change from this patch and resubmit it separately to me
> > if you want and I'll review when I have the time.
>
> Fine, I agree.
>
> I see those options (let me know if you see other options I have not
> mentioned):
>
> 1. I add this change (taking into account also intel ice) as a separate
> patch in this series and you may just ack it and Greg could merge
> together with the serdev one.
> 2. I prepare an independent patch for the GNSS change and only once this
> is merged I'll send a rebased v2 of this one.
> 3. I update this patch without this GNSS API change, that mean I will
> have to cast away the signed type from a few GNSS drivers.
>
> 1 is my preferred option, 2 is fine, but it seems a little bit of overdoing,
> 3 I would avoid, we are doing this cleanup to be a little bit more
> strongly typed and to prevent the kind of bugs that is the original trigger
> for this patch.
Changing the return type of gnss_insert_raw() is going to be a bit more
involved and should be done in a separate patch (e.g. you need to look
at gnss_usb_rx_complete() and ice_gnss_read() to avoid introducing new
warnings there).
And both option 2 and 3 will introduce conversion warnings (W=3, which
we have plenty of anyway) unless you add casts.
I suggest you go with 3, unless you insist on 2.
Johan
next prev parent reply other threads:[~2023-12-18 8:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 17:01 [PATCH v1] treewide, serdev: change receive_buf() return type to size_t Francesco Dolcini
2023-12-14 17:39 ` Francesco Dolcini
2023-12-15 13:26 ` Greg Kroah-Hartman
2023-12-15 13:36 ` Johan Hovold
2023-12-15 13:55 ` Francesco Dolcini
2023-12-15 16:18 ` Johan Hovold
2023-12-15 17:07 ` Francesco Dolcini
2023-12-18 8:35 ` Johan Hovold [this message]
2023-12-15 14:11 ` Greg Kroah-Hartman
2023-12-15 13:51 ` Johan Hovold
2023-12-15 13:59 ` Francesco Dolcini
2023-12-15 16:32 ` Johan Hovold
2023-12-17 12:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYAEOCMwZGMNvpNX@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).