From: Songwei Chai <quic_songchai@quicinc.com>
To: Nicolas Palix <nicolas.palix@imag.fr>,
Julia Lawall <Julia.Lawall@inria.fr>, <cocci@inria.fr>
Cc: <linux-kernel@vger.kernel.org>, <quic_tingweiz@quicinc.com>,
<quic_jinlmao@quicinc.com>
Subject: Re: [cocci] [PATCH v1] scripts: coccicheck: filter *.cocci files by MODE
Date: Fri, 6 Jun 2025 13:33:23 +0800 [thread overview]
Message-ID: <10e5207e-353e-4648-8e8d-6ee38d14907f@quicinc.com> (raw)
In-Reply-To: <e8221cc5-cf5b-49f8-871d-e49d6621fc6e@imag.fr>
On 6/6/2025 1:43 AM, Nicolas Palix wrote:
> Hi Songwei,
>
> Le 05/06/2025 à 06:44, Songwei Chai a écrit :
>> Enhance the coccicheck script to filter *.cocci files based on the
>> specified MODE (e.g., report, patch). This ensures that only compatible
>> semantic patch files are executed, preventing errors such as:
>>
>> "virtual rule report not supported"
>>
>> This error occurs when a .cocci file does not define a 'virtual <MODE>'
>> rule, yet is executed in that mode.
>
> I am fine with the idea even if the orignal idea was to be exhaustive
> in the implementation of the mode in each SP.
>
> However, silently discarding the patch is maybe not what one would
> expect as the considered SP will vary according to the mode.
>
> Hence, could I suggest to add an else branch reporting a warning at
> least ?
>
> Regards,
Sure, will update patch with else branch reporting a warning.
>
>>
>> For example:
>>
>> make coccicheck M=drivers/hwtracing/coresight/ MODE=report
>>
>> In this case, running "secs_to_jiffies.cocci" would trigger the error
>> because it lacks support for 'report' mode. With this change, such files
>> are skipped automatically, improving robustness and developer
>> experience.
>>
>> Signed-off-by: Songwei Chai <quic_songchai@quicinc.com>
>> ---
>> scripts/coccicheck | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index 0e6bc5a10320..18a69edcea66 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -270,7 +270,9 @@ fi
>> if [ "$COCCI" = "" ] ; then
>> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci'
>> -type f | sort`; do
>> - coccinelle $f
>> + if grep -q "virtual[[:space:]]\+$MODE" "$f"; then
>> + coccinelle $f
>> + fi
>> done
>> else
>> coccinelle $COCCI
>>
>
prev parent reply other threads:[~2025-06-12 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 4:44 [cocci] [PATCH v1] scripts: coccicheck: filter *.cocci files by MODE Songwei Chai
2025-06-05 17:43 ` Nicolas Palix
2025-06-06 5:33 ` Songwei Chai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10e5207e-353e-4648-8e8d-6ee38d14907f@quicinc.com \
--to=quic_songchai@quicinc.com \
--cc=Julia.Lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).