From: Ziyang Xuan <william.xuanziyang@huawei.com>
To: <Julia.Lawall@inria.fr>, <nicolas.palix@imag.fr>, <cocci@inria.fr>
Cc: <fabf@skynet.be>, <william.xuanziyang@huawei.com>
Subject: [cocci] [PATCH] scripts/coccinelle/free: add NULL test before dev_{put, hold} functions
Date: Thu, 16 Jun 2022 09:32:53 +0800 [thread overview]
Message-ID: <20220616013253.520310-1-william.xuanziyang@huawei.com> (raw)
Since commit b37a46683739 ("netdevice: add the case if dev is NULL"),
NULL check before dev_{put, hold} functions is not needed.
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
---
scripts/coccinelle/free/ifnulldev_put.cocci | 54 +++++++++++++++++++++
1 file changed, 54 insertions(+)
create mode 100644 scripts/coccinelle/free/ifnulldev_put.cocci
diff --git a/scripts/coccinelle/free/ifnulldev_put.cocci b/scripts/coccinelle/free/ifnulldev_put.cocci
new file mode 100644
index 000000000000..7ff36e6212ba
--- /dev/null
+++ b/scripts/coccinelle/free/ifnulldev_put.cocci
@@ -0,0 +1,54 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/// Since commit b37a46683739 ("netdevice: add the case if dev is NULL"),
+/// NULL check before dev_{put, hold} functions is not needed.
+///
+/// Based on ifnullfree.cocci by Fabian Frederick.
+///
+// Copyright: (C) 2022 Ziyang Xuan.
+// Comments: -
+// Options: --no-includes --include-headers
+
+virtual patch
+virtual org
+virtual report
+virtual context
+
+@r2 depends on patch@
+expression E;
+@@
+- if (E != NULL)
+(
+ __dev_put(E);
+|
+ dev_put(E);
+|
+ dev_put_track(E, ...);
+|
+ __dev_hold(E);
+|
+ dev_hold(E);
+|
+ dev_hold_track(E, ...);
+)
+
+@r depends on context || report || org @
+expression E;
+position p;
+@@
+
+* if (E != NULL)
+* \(__dev_put@p\|dev_put@p\|dev_put_track@p\|__dev_hold@p\|dev_hold@p\|
+* dev_hold_track@p\)(E, ...);
+
+@script:python depends on org@
+p << r.p;
+@@
+
+cocci.print_main("NULL check before dev_{put, hold} functions is not needed", p)
+
+@script:python depends on report@
+p << r.p;
+@@
+
+msg = "WARNING: NULL check before dev_{put, hold} functions is not needed."
+coccilib.report.print_report(p[0], msg)
--
2.25.1
next reply other threads:[~2022-06-25 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 1:32 Ziyang Xuan [this message]
2022-06-25 16:55 ` [cocci] [PATCH] scripts/coccinelle/free: add NULL test before dev_{put, hold} functions Markus Elfring
2022-06-29 12:32 ` Ziyang Xuan (William)
2022-06-29 18:42 ` [cocci] " Markus Elfring
2022-06-30 2:22 ` Ziyang Xuan (William)
2022-06-30 19:10 ` Markus Elfring
2022-07-16 13:38 ` [cocci] [PATCH] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616013253.520310-1-william.xuanziyang@huawei.com \
--to=william.xuanziyang@huawei.com \
--cc=Julia.Lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=fabf@skynet.be \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).