Coccinelle archive mirror
 help / color / mirror / Atom feed

From: Peter Senna Tschudin <peter.senna@linux.intel.com>
To: cocci@inria.fr
Subject: [cocci] Iterator macros
Date: Tue, 13 Aug 2024 08:15:19 +0200	[thread overview]
Message-ID: <25273c09-ded5-4f43-82ee-956f66a8cd0e@linux.intel.com> (raw)

Dear List, 

I am trying to make changes to a macro iterator from igt-gpu-tools*, and I am failing to use Coccinelle. My current attempt only captures about 1/2 of call sites, and I am not really sure how to ask Coccinelle to make the changes I want. Here is the pattern I am trying to change: 


From: 

const struct intel_execution_engine2 *e2; 
... 
for_each_ctx_engine(i915, ctx, e2) { 
    execbuf.flags = e2->flags; 
    gem_execbuf(i915, &execbuf); 
} 


To: 

struct intel_engine_data ied;
... 
for_each_ctx_engine(i915, ctx, ied) { 
    execbuf.flags = ied.current_engine->flags; 
    gem_execbuf(i915, &execbuf); 
} 

Changes I want: 
1. From `const struct intel_execution_engine2 *e2` to `struct intel_engine_data ied`. 
2. Replace the last argument of for_each_ctx_engine() following the change on previous step. 
3. Change references from `e2` to `ied.current_engine` inside the iterator statement. 

Here is my starting point that finds about half of the call sites: 

@r1@ 
iterator I =~ "for_each_ctx_engine"; 
statement S; 
@@ 
* I(...) 
S 

I assume that I should create other rules and import I from r1 as the core of the changes I want. Can you point me to an example to help me here?

Thank you,

Peter

* - https://gitlab.freedesktop.org/drm/igt-gpu-tools 

next             reply	other threads:[~2024-08-13  6:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13  6:15 Peter Senna Tschudin [this message]
2024-08-13  6:19 ` [cocci] Iterator macros Julia Lawall
2024-08-13  6:27   ` Peter Senna Tschudin
2024-08-13  6:34     ` Julia Lawall
2024-08-13 11:05       ` Andrzej Hajda
2024-08-13 11:19         ` Julia Lawall
2024-08-14  7:19         ` Julia Lawall
2024-08-14  7:57           ` Andrzej Hajda
2024-08-14  8:02             ` Julia Lawall
2024-08-14  7:21         ` Julia Lawall
2024-08-14  6:22     ` Julia Lawall
2024-08-14  9:44 ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25273c09-ded5-4f43-82ee-956f66a8cd0e@linux.intel.com \
    --to=peter.senna@linux.intel.com \
    --cc=cocci@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).