From: Julia Lawall <julia.lawall@inria.fr>
To: Luo Jie <quic_luoj@quicinc.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
cocci@inria.fr, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.linux.dev,
Catalin Marinas <catalin.marinas@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
Marc Zyngier <maz@kernel.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
Oliver Upton <oliver.upton@linux.dev>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>, Yury Norov <yury.norov@gmail.com>,
Zenghui Yu <yuzenghui@huawei.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
"Kiran Kumar C.S.K" <quic_kkumarcs@quicinc.com>,
Lei Wei <quic_leiwei@quicinc.com>,
Pavithra R <quic_pavir@quicinc.com>,
Suruchi Agarwal <quic_suruchia@quicinc.com>,
quic_linchen@quicinc.com
Subject: Re: [cocci] [PATCH v3 2/6] coccinelle: misc: Add field_modify script
Date: Mon, 19 May 2025 17:39:52 +0200 (CEST) [thread overview]
Message-ID: <6fe2aed9-f29e-4a77-5f47-855cfefe1973@inria.fr> (raw)
In-Reply-To: <1e3ba498-2bfb-4cab-ba13-5ab2c5b03ef9@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]
On Mon, 19 May 2025, Luo Jie wrote:
>
>
> On 4/24/2025 12:35 AM, Markus Elfring wrote:
> > …
> > > > -reg &= ~mask;
> > > > -reg |= FIELD_PREP
> > > > + FIELD_MODIFY
> > > > (mask,
> > > > + ®,
> > > > val
> > > > );
> > …
> > > With this code variant, there is no space prior to ®, here is the
> > > example code changes generated by the SmPL code as below, is this
> > > expected?
> > …
> > > +++ b/drivers/phy/starfive/phy-jh7110-dphy-tx.c
> > > @@ -244,8 +244,7 @@ static int stf_dphy_configure(struct phy
> > > i = stf_dphy_get_config_index(bitrate);
> > >
> > > tmp = readl(dphy->topsys + STF_DPHY_APBIFSAIF_SYSCFG(100));
> > > - tmp &= ~STF_DPHY_REFCLK_IN_SEL;
> > > - tmp |= FIELD_PREP(STF_DPHY_REFCLK_IN_SEL, STF_DPHY_REFCLK_12M);
> > > + FIELD_MODIFY(STF_DPHY_REFCLK_IN_SEL,&tmp, STF_DPHY_REFCLK_12M);
> > > writel(tmp, dphy->topsys + STF_DPHY_APBIFSAIF_SYSCFG(100));
> >
> > The Coccinelle software is still evolving somehow.
> > Thus your test result can trigger further development considerations.
> > I hope that clarifications and corresponding improvements can be achieved
> > also according to such source code layout concerns.
> >
> > Regards,
> > Markus
>
> OK, understand. I will keep the original patch as below for now, as we
> need to ensure the script generates code with the expected style.
> +- reg &= ~mask;
> +- reg |= FIELD_PREP(mask, val);
> ++ FIELD_MODIFY(mask, ®, val);
>
> In addition, below case is filed to request this improvement on the
> coccinelle project.
> https://github.com/coccinelle/coccinelle/issues/397
Thanks for the report.
julia
>
> Thanks.
>
next prev parent reply other threads:[~2025-05-19 15:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 10:47 [cocci] [PATCH v3 0/6] Add FIELD_MODIFY() helper Luo Jie
2025-04-17 10:47 ` [cocci] [PATCH v3 1/6] bitfield: " Luo Jie
2025-04-18 17:11 ` Yury Norov
2025-04-23 13:05 ` Jie Luo
2025-04-17 10:47 ` [cocci] [PATCH v3 2/6] coccinelle: misc: Add field_modify script Luo Jie
2025-04-23 11:01 ` Markus Elfring
2025-04-23 13:04 ` Jie Luo
2025-04-23 16:35 ` Markus Elfring
2025-05-19 13:44 ` Luo Jie
2025-05-19 15:39 ` Julia Lawall [this message]
2025-04-17 10:47 ` [cocci] [PATCH v3 3/6] arm64: tlb: Convert the opencoded field modify Luo Jie
2025-04-17 18:11 ` Russell King (Oracle)
2025-04-23 13:15 ` Jie Luo
2025-04-24 15:24 ` Keller, Jacob E
2025-04-23 16:54 ` Keller, Jacob E
2025-04-17 10:47 ` [cocci] [PATCH v3 4/6] arm64: nvhe: " Luo Jie
2025-04-17 11:23 ` Marc Zyngier
2025-04-18 15:14 ` Yury Norov
2025-04-18 15:34 ` Marc Zyngier
2025-04-23 17:48 ` Russell King (Oracle)
2025-04-23 18:27 ` Yury Norov
2025-04-23 19:11 ` Russell King (Oracle)
2025-04-23 19:40 ` Yury Norov
2025-04-17 10:47 ` [cocci] [PATCH v3 5/6] arm64: kvm: " Luo Jie
2025-04-17 10:47 ` [cocci] [PATCH v3 6/6] arm64: mm: " Luo Jie
2025-04-17 11:10 ` [cocci] [PATCH v3 0/6] Add FIELD_MODIFY() helper Marc Zyngier
2025-04-17 17:22 ` Andrew Lunn
2025-04-17 17:45 ` Marc Zyngier
2025-04-18 15:08 ` Yury Norov
2025-04-18 15:35 ` Marc Zyngier
2025-04-18 17:04 ` Yury Norov
2025-04-23 13:19 ` Jie Luo
2025-04-23 17:44 ` Russell King (Oracle)
2025-04-23 18:44 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fe2aed9-f29e-4a77-5f47-855cfefe1973@inria.fr \
--to=julia.lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=cocci@inria.fr \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maz@kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=oliver.upton@linux.dev \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).