From: Gal Pressman <gal@nvidia.com>
To: Johan Hovold <johan@kernel.org>,
Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>
Cc: Jakub Kicinski <kuba@kernel.org>,
Alexei Lazar <alazar@nvidia.com>, Simon Horman <horms@kernel.org>,
cocci@inria.fr, linux-kernel@vger.kernel.org
Subject: Re: [cocci] [PATCH] Revert "scripts/coccinelle: Find PTR_ERR() to %pe candidates"
Date: Wed, 29 Oct 2025 15:59:50 +0200 [thread overview]
Message-ID: <826f2fdb-bad8-44f4-8c8e-9353c3de73cd@nvidia.com> (raw)
In-Reply-To: <20251029132922.17329-1-johan@kernel.org>
Hi Johan,
On 29/10/2025 15:29, Johan Hovold wrote:
> This reverts commit 57c49d2355729c12475554b4c51dbf830b02d08d.
>
> Using "%pe" to print errnos is in no way mandated and a driver authors
> may chose not to use it, for example, for consistency reasons.
>
> Drop the recently added cocci script that has gotten the build bots to
> send warning emails about perfectly valid code and which will likely
> only result in churn and inconsistency.
>
> Link: https://lore.kernel.org/all/aQHi4nUfIlcN1ac6@hovoldconsulting.com/
> Signed-off-by: Johan Hovold <johan@kernel.org>
The test by no means mandates authors to use %pe, as the output says:
WARNING: Consider using %pe to print PTR_ERR()
"Consider" :).
I would consider it best practice to use it, and a few drivers were
converted thanks to this test.
If the issue is with automatic build bots, then maybe this test should
be excluded from them, rather than deleted?
next prev parent reply other threads:[~2025-10-29 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:29 [cocci] [PATCH] Revert "scripts/coccinelle: Find PTR_ERR() to %pe candidates" Johan Hovold
2025-10-29 13:59 ` Gal Pressman [this message]
2025-10-29 14:04 ` Julia Lawall
2025-10-29 17:26 ` Jakub Kicinski
2025-10-29 16:38 ` Johan Hovold
2025-10-29 17:00 ` [cocci] " Markus Elfring
2025-10-29 17:35 ` [cocci] [PATCH] " Gal Pressman
2025-10-30 14:06 ` Johan Hovold
2025-10-30 14:36 ` Gal Pressman
2025-10-31 14:10 ` Johan Hovold
2025-10-30 7:36 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=826f2fdb-bad8-44f4-8c8e-9353c3de73cd@nvidia.com \
--to=gal@nvidia.com \
--cc=Julia.Lawall@inria.fr \
--cc=alazar@nvidia.com \
--cc=cocci@inria.fr \
--cc=horms@kernel.org \
--cc=johan@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).