From: Markus Elfring <Markus.Elfring@web.de>
To: Joel Granados <j.granados@samsung.com>,
kernel-janitors@vger.kernel.org, cocci@inria.fr
Cc: LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [cocci] latencytop: Use seq_putc() in lstats_show()
Date: Tue, 16 Jul 2024 19:06:06 +0200 [thread overview]
Message-ID: <a1b7f067-efa9-4550-8351-8923a71826fa@web.de> (raw)
In-Reply-To: <20240716154520.vtlqv4jxlihy2h7r@joelS2.panther.com>
> Not sure why this got forwarded to me.
The script “get_maintainer.pl” pointed your recent contribution out.
>> A single line break should be put into a sequence.
>> Thus use the corresponding function “seq_putc”.
>>
>> This issue was transformed by using the Coccinelle software.
>
> A couple of comments while I'm here:
> * The "why" is not clear; please clarify why a single line break should
> be put into a sequence.
This is a desired data processing effect here.
https://elixir.bootlin.com/linux/v6.10/source/kernel/latencytop.c#L263
> * I don't think that a one liner merits the "coccinelle" comment.
> However, if you *really* think it should be there, please add more
> information, like the conccinell script.
I would appreciate if another SmPL script can eventually be integrated
for the coccicheck tool.
Regards,
Markus
parent reply other threads:[~2024-07-16 17:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240716154520.vtlqv4jxlihy2h7r@joelS2.panther.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1b7f067-efa9-4550-8351-8923a71826fa@web.de \
--to=markus.elfring@web.de \
--cc=arjan@linux.intel.com \
--cc=cocci@inria.fr \
--cc=j.granados@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).