From: Johan Hovold <johan@kernel.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.de,
cocci@inria.fr, Jakub Kicinski <kuba@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [cocci] drivers/phy/ti/phy-omap-usb2.c:442:4-11: WARNING: Consider using %pe to print PTR_ERR() (fwd)
Date: Wed, 29 Oct 2025 10:48:18 +0100 [thread overview]
Message-ID: <aQHi4nUfIlcN1ac6@hovoldconsulting.com> (raw)
In-Reply-To: <5f43ff47-70d4-8c53-efd3-6effb2e9afcb@inria.fr>
On Tue, Oct 28, 2025 at 05:02:40PM +0100, Julia Lawall wrote:
> ---------- Forwarded message ----------
> Date: Tue, 28 Oct 2025 22:32:58 +0800
> From: kernel test robot <lkp@intel.com>
> To: oe-kbuild@lists.linux.dev
> Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
> Subject: drivers/phy/ti/phy-omap-usb2.c:442:4-11: WARNING: Consider using %pe to
> print PTR_ERR()
>
> BCC: lkp@intel.com
> CC: oe-kbuild-all@lists.linux.dev
> CC: linux-kernel@vger.kernel.org
> TO: Johan Hovold <johan@kernel.org>
> CC: Vinod Koul <vkoul@kernel.org>
> CC: Neil Armstrong <neil.armstrong@linaro.org>
>
> Hi Johan,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: fd57572253bc356330dbe5b233c2e1d8426c66fd
> commit: 8209b3f79703b8ff09f84a79c46ead0df7260d9f phy: ti: omap-usb2: enable compile testing
> date: 3 months ago
> :::::: branch date: 21 hours ago
> :::::: commit date: 3 months ago
> config: sparc64-randconfig-r064-20251028 (https://download.01.org/0day-ci/archive/20251028/202510282255.6lFijMzE-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Julia Lawall <julia.lawall@inria.fr>
> | Closes: https://lore.kernel.org/r/202510282255.6lFijMzE-lkp@intel.com/
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/phy/ti/phy-omap-usb2.c:442:4-11: WARNING: Consider using %pe to print PTR_ERR()
Why is this framed as a warning? It's at best a suggestion for a style
change that not everyone agrees with (me included). A driver may want to
use numeric errnos for consistency, and there certainly nothing
"redundant" in calling PTR_ERR() as the cocci script claims.
https://lore.kernel.org/all/1758192227-701925-2-git-send-email-tariqt@nvidia.com/
Please consider dropping this from the tree or at least from what the
build bots run to avoid the unnecessary noise and churn this causes.
Johan
parent reply other threads:[~2025-10-29 13:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5f43ff47-70d4-8c53-efd3-6effb2e9afcb@inria.fr>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQHi4nUfIlcN1ac6@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=cocci@inria.fr \
--cc=julia.lawall@inria.fr \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=oe-kbuild-all@lists.linux.de \
--cc=tariqt@nvidia.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).