From: Julia Lawall <julia.lawall@inria.fr>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
Kees Cook <kees@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-hardening@vger.kernel.org, cocci@inria.fr,
linux-kernel@vger.kernel.org
Subject: Re: [cocci] [PATCH] coccinelle: Add str_off_on() and str_no_yes() rules
Date: Sun, 27 Oct 2024 16:25:51 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2410271624210.3498@hadrien> (raw)
In-Reply-To: <CAHp75VeeUKWakOWW7ft8BB9Gg=29_z93fCjDk_VGsqd8py878A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Sun, 27 Oct 2024, Andy Shevchenko wrote:
> On Sun, Oct 27, 2024 at 2:59 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
> >
> > In addition to str_on_off() and str_yes_no(), add rules to search for
> > str_off_on() and str_no_yes() replacements.
>
> I don't know cocci well enough, but this does simply not scale. We
> also have cases where "Yes"/"No", "YES"/"NO" and all possible
> variations of that.
Andy, are you concerned about the number of such functions in the kernel
or the number of rules in the semantic patch. There are indeed more
concise ways to write the semantic patch.
julia
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
prev parent reply other threads:[~2024-10-27 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 12:58 [cocci] [PATCH] coccinelle: Add str_off_on() and str_no_yes() rules Thorsten Blum
2024-10-27 15:06 ` Andy Shevchenko
2024-10-27 15:25 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2410271624210.3498@hadrien \
--to=julia.lawall@inria.fr \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=cocci@inria.fr \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).