From: Julia Lawall <julia.lawall@inria.fr>
To: Songwei Chai <quic_songchai@quicinc.com>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
cocci@inria.fr, linux-kernel@vger.kernel.org,
quic_tingweiz@quicinc.com, quic_jinlmao@quicinc.com
Subject: Re: [cocci] [PATCH v2] scripts: coccicheck: filter *.cocci files by MODE
Date: Fri, 7 Nov 2025 09:05:24 +0100 (CET) [thread overview]
Message-ID: <f4376c72-b255-4cc-959a-8c947addb4ca@inria.fr> (raw)
In-Reply-To: <20250606060936.2756980-1-quic_songchai@quicinc.com>
On Fri, 6 Jun 2025, Songwei Chai wrote:
> Enhance the coccicheck script to filter *.cocci files based on the
> specified MODE (e.g., report, patch). This ensures that only compatible
> semantic patch files are executed, preventing errors such as:
>
> "virtual rule report not supported"
>
> This error occurs when a .cocci file does not define a 'virtual <MODE>'
> rule, yet is executed in that mode.
>
> For example:
>
> make coccicheck M=drivers/hwtracing/coresight/ MODE=report
>
> In this case, running "secs_to_jiffies.cocci" would trigger the error
> because it lacks support for 'report' mode. With this change, such files
> are skipped automatically, improving robustness and developer
> experience.
Pushed to my tree (for-6.19 branch)
>
> Signed-off-by: Songwei Chai <quic_songchai@quicinc.com>
> ---
> scripts/coccicheck | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 0e6bc5a10320..89d591af5f3e 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -270,7 +270,11 @@ fi
>
> if [ "$COCCI" = "" ] ; then
> for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> - coccinelle $f
> + if grep -q "virtual[[:space:]]\+$MODE" "$f"; then
> + coccinelle $f
> + else
> + echo "warning: Skipping $f as it does not match mode '$MODE'"
> + fi
> done
> else
> coccinelle $COCCI
>
>
prev parent reply other threads:[~2025-11-07 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 6:09 [cocci] [PATCH v2] scripts: coccicheck: filter *.cocci files by MODE Songwei Chai
2025-06-06 7:26 ` Nicolas Palix
2025-10-27 2:39 ` Songwei Chai
2025-11-05 1:53 ` Songwei Chai
2025-11-07 8:05 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4376c72-b255-4cc-959a-8c947addb4ca@inria.fr \
--to=julia.lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).