ConnMan network manager
 help / color / mirror / Atom feed
From: Ram Subramanian <ram.subramanian@getcruise.com>
To: connman@lists.linux.dev
Cc: Ram Subramanian <ram.subramanian@getcruise.com>
Subject: [PATCH] iwd: set network to connected if it is already
Date: Thu, 18 Apr 2024 13:11:51 -0700	[thread overview]
Message-ID: <20240418201151.624654-1-ram.subramanian@getcruise.com> (raw)

Without this, connman will wait for a "Connected" signal from iwd, which
is only emitted when iwd connects to a network. If it is already
connected by the time create_network() is run, that network will be
stuck in limbo.
---
 plugins/iwd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/plugins/iwd.c b/plugins/iwd.c
index 1955140d..19229c10 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -1830,6 +1830,9 @@ static void create_network(GDBusProxy *proxy)
 			network_property_change, NULL);
 
 	add_network(path, iwdn);
+
+	if (iwdn->connected)
+		update_network_connected(iwdn);
 }
 
 static void known_network_property_change(GDBusProxy *proxy, const char *name,
-- 
2.43.2


-- 


*Confidentiality Note:* We care about protecting our proprietary 
information, confidential material, and trade secrets. This message may 
contain some or all of those things. Cruise will suffer material harm if 
anyone other than the intended recipient disseminates or takes any action 
based on this message. If you have received this message (including any 
attachments) in error, please delete it immediately and notify the sender 
promptly.

             reply	other threads:[~2024-04-18 20:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 20:11 Ram Subramanian [this message]
2024-04-22 22:50 ` [PATCH] iwd: set network to connected if it is already patchwork-bot+connman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418201151.624654-1-ram.subramanian@getcruise.com \
    --to=ram.subramanian@getcruise.com \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).