From: Jonghwan Choi <jhbird.choi@samsung.com>
To: 'Viresh Kumar' <viresh.kumar@linaro.org>,
'Amit Kachhap' <amit.kachhap@gmail.com>
Cc: 'Kukjin Kim' <kgene.kim@samsung.com>,
'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
linux-arm-kernel@lists.infradead.org,
"'open list:CPU FREQUENCY DRI...'" <cpufreq@vger.kernel.org>
Subject: RE: [PATCH 2/2] cpufreq: Remove exynos_sort_descend_freq_table in exynos5440-cpufreq.c
Date: Tue, 29 Apr 2014 16:05:28 +0900 [thread overview]
Message-ID: <001501cf6379$66fea1f0$34fbe5d0$@samsung.com> (raw)
In-Reply-To: <CAKohponkT9o4WVUo=fNmVq+kMjm68Z3hdFVMhe7+8qsKPPc2CQ@mail.gmail.com>
Thanks to Amit Kachhap & Viresh Kumar
> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar@linaro.org]
> Sent: Tuesday, April 29, 2014 3:21 PM
> To: Amit Kachhap
> Cc: Jonghwan Choi; Kukjin Kim; linux-samsung-soc; Rafael J. Wysocki;
> linux-arm-kernel@lists.infradead.org; open list:CPU FREQUENCY DRI...
> Subject: Re: [PATCH 2/2] cpufreq: Remove exynos_sort_descend_freq_table in
> exynos5440-cpufreq.c
>
> On 29 April 2014 11:44, Amit Kachhap <amit.kachhap@gmail.com> wrote:
> > In the frequency table dts file, the frequencies are arranged in
> > descending order which maps 1 to 1 with other frequency parameter to
> > be calculated and programmed in some registers.
> > But the OPP library works by generating the frequencies in ascending
> > order which breaks the above logic. Ideally i should expect frequency
> > values in same order as what is supplied.
> > So OPP library should not change the order or should take input flags
> > flags like, dev_pm_opp_init_cpufreq_table(TABLE_ORDER_ASCEND|
> > TABLE_ORDER_DESCEND|TABLE_ORDER_ORIGINAL )
>
> Looks a good idea :)
>
> This is what I wrote in another thread:
>
> What I would recommend is, use .driver_data field to hold what has to be
> written to hardware for any frequency. And then simply use driver_data
> instead of index.
prev parent reply other threads:[~2014-04-29 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 5:24 [PATCH 2/2] cpufreq: Remove exynos_sort_descend_freq_table in exynos5440-cpufreq.c Jonghwan Choi
2014-04-29 5:35 ` Viresh Kumar
2014-04-29 6:14 ` Amit Kachhap
2014-04-29 6:21 ` Viresh Kumar
2014-04-29 7:05 ` Jonghwan Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001501cf6379$66fea1f0$34fbe5d0$@samsung.com' \
--to=jhbird.choi@samsung.com \
--cc=amit.kachhap@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).