From: Joe Perches <joe@perches.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: Reformat printk() statement
Date: Mon, 10 Mar 2014 09:49:18 -0700 [thread overview]
Message-ID: <1394470158.24244.18.camel@joe-AO722> (raw)
In-Reply-To: <f29b7db5-e5a2-48d8-ae42-8ec562c4c4f6@CO9EHSMHS025.ehs.local>
On Mon, 2014-03-10 at 09:35 -0700, Sören Brinkmann wrote:
> Hi Joe,
Hello Sören:
> On Sun, 2014-03-09 at 09:07PM -0700, Joe Perches wrote:
> > On Mon, 2014-03-10 at 11:53 +0800, Viresh Kumar wrote:
> > > On 7 March 2014 01:34, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> > > > Reformat a printk statement to:
> > > > - use pr_warn
> > > > - bring the whole string into a single line in favor of being able to
> > > > grep for the message (ignoring the 80 char limit)
> > > >
> > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > []
> > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > A more comprehensive patch would be to:
> >
> > Add missing newlines
> > Coalesce format fragments
> > Convert printks to pr_<level>
> > Align arguments
>
> I agree. But I didn't want to spend time on "fixing" formatting without
> knowing it will be accepted. Also, I was grepping for the message I
> ended up changing because on an issue I actually needed to fix.
>
> Do you want me to squash your changes into the patch I submitted? Or do
> you wanna pick up mine and submit your patch?
What I sent incorporates your change.
If Viresh or Rafael want me to sign it, I will,
Original-patch-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: Joe Perches <joe@perches.com>
otherwise, feel free to resend it with your signature.
cheers, Joe
prev parent reply other threads:[~2014-03-10 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 17:34 [PATCH] cpufreq: Reformat printk() statement Soren Brinkmann
2014-03-10 3:53 ` Viresh Kumar
2014-03-10 4:07 ` Joe Perches
2014-03-10 4:15 ` Viresh Kumar
2014-03-10 16:35 ` Sören Brinkmann
2014-03-10 16:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394470158.24244.18.camel@joe-AO722 \
--to=joe@perches.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).