From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: rjw@rjwysocki.net, mroos@linux.ee, viresh.kumar@linaro.org
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com
Subject: [PATCH v2 0/5] Cpufreq frequency serialization fixes
Date: Tue, 29 Apr 2014 00:23:54 +0530 [thread overview]
Message-ID: <20140428185331.28755.899.stgit@srivatsabhat.in.ibm.com> (raw)
Hi,
Meelis Roos reported hangs during boot in the longhaul cpufreq driver, after
commit 12478cf0c55 (cpufreq: Make sure frequency transitions are serialized).
The root-cause of this issue is the extra invocation of the
cpufreq_freq_transition_begin() and cpufreq_freq_transition_end() APIs in the
longhaul driver. I found similar issues in the powernow-k6 and powernow-k7
drivers as well. This patchset fixes the issue in all the 3 drivers and also
adds a debug infrastructure to catch such issues easily.
Patches 1-4 fix the regression in longhaul, powernow-k6 and powernow-k7
drivers. (Patch 2 fixes a different bug in powernow-k6, and it is kept as a
separate patch instead of merging it with patch 3, because I felt that it was
a bit subtle and needed attention in a separate patch).
Patch 5 adds a debug infrastructure to the cpufreq core to catch such problems
more easily in the future.
Changes in v2:
--------------
* Modified patch 1 to take error returns into account, as pointed out by
Viresh.
* Added patch 2 to fix the existing issue in the powernow-k6 driver, pointed
out by Viresh.
* Added patch 5 to introduce a debug infrastructure to catch such issues
easily.
Srivatsa S. Bhat (5):
cpufreq, longhaul: Fix double invocation of cpufreq_freq_transition_begin/end
cpufreq, powernow-k6: Fix incorrect comparison with max_multipler
cpufreq, powernow-k6: Fix double invocation of cpufreq_freq_transition_begin/end
cpufreq, powernow-k7: Fix double invocation of cpufreq_freq_transition_begin/end
cpufreq: Catch double invocations of cpufreq_freq_transition_begin/end
drivers/cpufreq/cpufreq.c | 12 ++++++++++++
drivers/cpufreq/longhaul.c | 36 ++++++++++++++++++++++++------------
drivers/cpufreq/powernow-k6.c | 23 +++++++++++++----------
drivers/cpufreq/powernow-k7.c | 4 ----
include/linux/cpufreq.h | 1 +
5 files changed, 50 insertions(+), 26 deletions(-)
Thanks,
Srivatsa S. Bhat
IBM Linux Technology Center
next reply other threads:[~2014-04-28 18:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 18:53 Srivatsa S. Bhat [this message]
2014-04-28 18:54 ` [PATCH v2 1/5] cpufreq, longhaul: Fix double invocation of cpufreq_freq_transition_begin/end Srivatsa S. Bhat
2014-04-28 18:54 ` [PATCH v2 2/5] cpufreq, powernow-k6: Fix incorrect comparison with max_multipler Srivatsa S. Bhat
2014-04-28 18:54 ` [PATCH v2 3/5] cpufreq, powernow-k6: Fix double invocation of cpufreq_freq_transition_begin/end Srivatsa S. Bhat
2014-04-28 18:54 ` [PATCH v2 4/5] cpufreq, powernow-k7: " Srivatsa S. Bhat
2014-04-28 18:55 ` [PATCH v2 5/5] cpufreq: Catch double invocations " Srivatsa S. Bhat
2014-04-29 4:51 ` Viresh Kumar
2014-04-29 4:55 ` Viresh Kumar
2014-04-29 6:16 ` Srivatsa S. Bhat
2014-04-29 6:49 ` Viresh Kumar
2014-04-29 7:35 ` Srivatsa S. Bhat
2014-04-29 8:04 ` Viresh Kumar
2014-04-29 8:10 ` Srivatsa S. Bhat
2014-04-29 6:08 ` Srivatsa S. Bhat
2014-04-28 20:57 ` [PATCH v2 0/5] Cpufreq frequency serialization fixes Meelis Roos
2014-04-28 23:47 ` Rafael J. Wysocki
2014-04-29 5:59 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428185331.28755.899.stgit@srivatsabhat.in.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).