From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Mark Langsdorf <mark.langsdorf@calxeda.com>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
guohanjun@huawei.com
Subject: Re: [PATCH] cpufreq: highbank: fix ARM_HIGHBANK_CPUFREQ dependency warning
Date: Thu, 10 Apr 2014 11:06:17 +0800 [thread overview]
Message-ID: <53460AA9.7030801@huawei.com> (raw)
In-Reply-To: <1453884.JQRzhD9Q31@vostro.rjw.lan>
Hi Rafael,
On 04/10 10:18, Rafael J. Wysocki wrote:
> On Wednesday, April 09, 2014 09:58:26 AM Viresh Kumar wrote:
>> On 9 April 2014 08:04, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>> When make ARCH=arm multi_v7_defconfig, we get the following warnings:
>>>
>>> warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has
>>> unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK
>>> && REGULATOR && OF && THERMAL && CPU_THERMAL)
>>>
>>> To fix this, make ARM_HIGHBANK_CPUFREQ depend on ARCH_HAS_CPUFREQ and
>>> REGULATOR instead of selecting them, PM_OPP will be selected by ARCH_HAS_CPUFREQ.
>>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> Well, it doesn't work as intended, I'm afraid:
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> head: 588bc73d890c5dea35b7982a368c0e95089d5389
> commit: 51be80edc69390521622df71855d86da4e358488 [67/68] cpufreq: highbank: fix ARM_HIGHBANK_CPUFREQ dependency warning
> config: make ARCH=i386 allyesconfig
>
> All warnings:
>
> warning: (GENERIC_CPUFREQ_CPU0 && ARM_BIG_LITTLE_CPUFREQ && ARM_EXYNOS5440_CPUFREQ) selects PM_OPP which has unmet direct dependencies (ARCH_HAS_OPP)
I don't think this is my issue, without this patch，the warning is still there.
warning: (GENERIC_CPUFREQ_CPU0 && ARM_BIG_LITTLE_CPUFREQ && ARM_EXYNOS5440_CPUFREQ && ARM_HIGHBANK_CPUFREQ) selects PM_OPP which has unmet direct dependencies (ARCH_HAS_OPP)
this warning is caused by commit 109df086e(cpufreq: Select PM_OPP rather than depending on it),
so could you merge this patch? I will send a revert patch to solve this issue, what is your opinion?
Regards,
Kefeng
>
>>> ---
>>> drivers/cpufreq/Kconfig.arm | 6 +-----
>>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>> --
>> To unsubscribe from this list: send the line "unsubscribe cpufreq" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-04-10 3:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 2:34 [PATCH] cpufreq: highbank: fix ARM_HIGHBANK_CPUFREQ dependency warning Kefeng Wang
2014-04-09 4:28 ` Viresh Kumar
2014-04-10 2:18 ` Rafael J. Wysocki
2014-04-10 3:06 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53460AA9.7030801@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=cpufreq@vger.kernel.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.langsdorf@calxeda.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).