From: "Rafał Bilski" <rafalbilski@interia.pl>
To: Dave Jones <davej@redhat.com>, Ben Hutchings <ben@decadent.org.uk>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
cpufreq@vger.kernel.org
Subject: Re: [PATCH 1/2] longhaul: Mark it as dangerous in Kconfig
Date: Mon, 09 Jun 2014 19:05:25 +0100 [thread overview]
Message-ID: <5395F765.90405@interia.pl> (raw)
In-Reply-To: <20140609000205.GA15035@redhat.com>
W dniu 09.06.2014 01:02, Dave Jones pisze:
> On Mon, Jun 09, 2014 at 12:20:42AM +0100, Ben Hutchings wrote:
> > longhaul quickly caused hard lockups and possibly killed the memory
> > module on my EPIA-PD board. It is commented as:
> >
> > 'BIG FAT DISCLAIMER: Work in progress code. Possibly *dangerous*'
>
> that last part may have been overly dramatic. When I was originally
> writing this driver I was using pre-production cpu's which were
> marginal to begin with. Production hw should have been more tolerant.
> What didn't help was a lot of the EPIAs were made with *Really*
> shitty capacitors that would pop open and ooze over the boards. Might want
> to eyeball those, you can usually tell when they've gone bad.
>
> > Let's put another warning where people are more likely to see it.
>
> That said, I'm not against itbeing marked BROKEN (I thought it
> already was), and certainly don't recommend distros enabling it.
>
> I'd also not stand in the way of someone throwing it out completely
> given the small amount of systems out there likely still running this.
>
> Dave
>
>
If I may I would like to agree with Dave Jones. There is no point
in changing text which nobody will see in their logs. If somebody
wants to use the driver it is very easy now to compile module outside
the kernel tree. I didn't expected possibility of hardware damage
because driver just puts CPU to sleep to change frequency, but
VIA products have been full of bugs so looks like anything is
possible. Another matter is we have got these "dynamic ticks" in kernel
now and code in driver expects monotonic ticks and abuses them a bit
in order to be able to wake CPU from sleep. Does it make it obsolete?
Rafał Bilski
next prev parent reply other threads:[~2014-06-09 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 23:20 [PATCH 1/2] longhaul: Mark it as dangerous in Kconfig Ben Hutchings
2014-06-09 0:02 ` Dave Jones
2014-06-09 0:30 ` Ben Hutchings
2014-06-09 18:05 ` Rafał Bilski [this message]
2014-06-09 4:41 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395F765.90405@interia.pl \
--to=rafalbilski@interia.pl \
--cc=ben@decadent.org.uk \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).