From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Shawn Guo <shawn.guo@freescale.com>,
cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH RESEND 1/2] cpufreq: imx6q: Drop devm_clk/regulator_get usage
Date: Tue, 22 Apr 2014 00:08:20 +0200 [thread overview]
Message-ID: <6608663.Uaf3xkE0GI@vostro.rjw.lan> (raw)
In-Reply-To: <1397468817-23266-1-git-send-email-p.zabel@pengutronix.de>
On Monday, April 14, 2014 11:46:56 AM Philipp Zabel wrote:
> This driver is using devres managed calls incorrectly, giving the cpu0
> device as first parameter instead of the cpufreq platform device.
> This results in resources not being freed if the cpufreq platform device
> is unbound, for example if probing has to be deferred for a missing
> regulator.
> Supporting probe deferral properly is a prerequisite to enabling the
> internal LDO bypass on i.MX6 and regulating the CPU voltage with an
> external regulator.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Acked-by: Shawn Guo <shawn.guo@freescale.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> This didn't turn up in v3.15-rc1. Resend in case it fell through the cracks.
Please resend with a CC to linux-pm@vger.kernel.org (and you can drop cpufreq
from the CC list).
> ---
> drivers/cpufreq/imx6q-cpufreq.c | 53 ++++++++++++++++++++++++++++++-----------
> 1 file changed, 39 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index e27fca8..92a82ec 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -170,25 +170,25 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
> return -ENOENT;
> }
>
> - arm_clk = devm_clk_get(cpu_dev, "arm");
> - pll1_sys_clk = devm_clk_get(cpu_dev, "pll1_sys");
> - pll1_sw_clk = devm_clk_get(cpu_dev, "pll1_sw");
> - step_clk = devm_clk_get(cpu_dev, "step");
> - pll2_pfd2_396m_clk = devm_clk_get(cpu_dev, "pll2_pfd2_396m");
> + arm_clk = clk_get(cpu_dev, "arm");
> + pll1_sys_clk = clk_get(cpu_dev, "pll1_sys");
> + pll1_sw_clk = clk_get(cpu_dev, "pll1_sw");
> + step_clk = clk_get(cpu_dev, "step");
> + pll2_pfd2_396m_clk = clk_get(cpu_dev, "pll2_pfd2_396m");
> if (IS_ERR(arm_clk) || IS_ERR(pll1_sys_clk) || IS_ERR(pll1_sw_clk) ||
> IS_ERR(step_clk) || IS_ERR(pll2_pfd2_396m_clk)) {
> dev_err(cpu_dev, "failed to get clocks\n");
> ret = -ENOENT;
> - goto put_node;
> + goto put_clk;
> }
>
> - arm_reg = devm_regulator_get(cpu_dev, "arm");
> - pu_reg = devm_regulator_get(cpu_dev, "pu");
> - soc_reg = devm_regulator_get(cpu_dev, "soc");
> + arm_reg = regulator_get(cpu_dev, "arm");
> + pu_reg = regulator_get(cpu_dev, "pu");
> + soc_reg = regulator_get(cpu_dev, "soc");
> if (IS_ERR(arm_reg) || IS_ERR(pu_reg) || IS_ERR(soc_reg)) {
> dev_err(cpu_dev, "failed to get regulators\n");
> ret = -ENOENT;
> - goto put_node;
> + goto put_reg;
> }
>
> /*
> @@ -201,21 +201,21 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
> ret = of_init_opp_table(cpu_dev);
> if (ret < 0) {
> dev_err(cpu_dev, "failed to init OPP table: %d\n", ret);
> - goto put_node;
> + goto put_reg;
> }
>
> num = dev_pm_opp_get_opp_count(cpu_dev);
> if (num < 0) {
> ret = num;
> dev_err(cpu_dev, "no OPP table is found: %d\n", ret);
> - goto put_node;
> + goto put_reg;
> }
> }
>
> ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table);
> if (ret) {
> dev_err(cpu_dev, "failed to init cpufreq table: %d\n", ret);
> - goto put_node;
> + goto put_reg;
> }
>
> /* Make imx6_soc_volt array's size same as arm opp number */
> @@ -301,7 +301,24 @@ soc_opp_out:
>
> free_freq_table:
> dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table);
> -put_node:
> +put_reg:
> + if (!IS_ERR(arm_reg))
> + regulator_put(arm_reg);
> + if (!IS_ERR(pu_reg))
> + regulator_put(pu_reg);
> + if (!IS_ERR(soc_reg))
> + regulator_put(soc_reg);
> +put_clk:
> + if (!IS_ERR(arm_clk))
> + clk_put(arm_clk);
> + if (!IS_ERR(pll1_sys_clk))
> + clk_put(pll1_sys_clk);
> + if (!IS_ERR(pll1_sw_clk))
> + clk_put(pll1_sw_clk);
> + if (!IS_ERR(step_clk))
> + clk_put(step_clk);
> + if (!IS_ERR(pll2_pfd2_396m_clk))
> + clk_put(pll2_pfd2_396m_clk);
> of_node_put(np);
> return ret;
> }
> @@ -310,6 +327,14 @@ static int imx6q_cpufreq_remove(struct platform_device *pdev)
> {
> cpufreq_unregister_driver(&imx6q_cpufreq_driver);
> dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table);
> + regulator_put(arm_reg);
> + regulator_put(pu_reg);
> + regulator_put(soc_reg);
> + clk_put(arm_clk);
> + clk_put(pll1_sys_clk);
> + clk_put(pll1_sw_clk);
> + clk_put(step_clk);
> + clk_put(pll2_pfd2_396m_clk);
>
> return 0;
> }
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-04-21 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 9:46 [PATCH RESEND 1/2] cpufreq: imx6q: Drop devm_clk/regulator_get usage Philipp Zabel
2014-04-14 9:46 ` [PATCH RESEND 2/2] cpufreq: imx6q: Remove unused include Philipp Zabel
2014-04-21 22:08 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6608663.Uaf3xkE0GI@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).