From: Viresh Kumar <viresh.kumar@linaro.org>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: Rashika Kheria <rashika.kheria@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>
Subject: Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c
Date: Mon, 3 Mar 2014 12:50:43 +0530 [thread overview]
Message-ID: <CAKohpok3UZbQZBFM5FWP3tXFDGHm+j3-zP-rYUCF1fPTxAYp9g@mail.gmail.com> (raw)
In-Reply-To: <CA+C-WL-pnQne-Cz8MuSFPpcHH33ARbRRm-R6VT9aEKzgNHZQQg@mail.gmail.com>
On 3 March 2014 09:12, Patrick Palka <patrick@parcs.ath.cx> wrote:
> -Wmissing-prototypes warns when a non-static function is defined
> before a corresponding prototype (usually inside an included header
> file) is declared. In such a case, it is impossible to reference the
> non-static function from another file, and therefore the function
> should be marked static (usually). Hope that makes sense!
I understand that it should be made static as we don't have a
prototype in any other header file, but I thought we shouldn't
get the warning we are getting.
warning: no previous prototype for 'show_boost'
Because we have prototype/definition of function before it is used.
Maybe a warning like:
local function should be marked static could have been there ;)
next prev parent reply other threads:[~2014-03-03 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <linux-pm@vger.kernel.org20140226154625.GA10701@rashika>
2014-02-26 16:38 ` [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c Rashika Kheria
2014-02-26 16:41 ` Josh Triplett
2014-02-26 16:45 ` Rashika Kheria
2014-02-26 17:08 ` Josh Triplett
2014-02-27 5:25 ` Viresh Kumar
2014-03-03 0:29 ` Viresh Kumar
2014-03-03 3:42 ` Patrick Palka
2014-03-03 7:20 ` Viresh Kumar [this message]
2014-02-26 16:52 ` Dirk Brandewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohpok3UZbQZBFM5FWP3tXFDGHm+j3-zP-rYUCF1fPTxAYp9g@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@parcs.ath.cx \
--cc=rashika.kheria@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).